public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <khali@linux-fr.org>
To: Robert Hancock <hancockrwd@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>, lm-sensors@lm-sensors.org
Subject: Re: [lm-sensors] coretemp support for Core i5 CPU
Date: Sun, 20 Sep 2009 21:16:20 +0200	[thread overview]
Message-ID: <20090920211620.1c18d7fb@hyperion.delvare> (raw)
In-Reply-To: <4AB5DE1F.1020004@gmail.com>

Hi Robert,

On Sun, 20 Sep 2009 01:47:43 -0600, Robert Hancock wrote:
> Trying to load the coretemp driver for CPU temperature monitoring on a 
> Core i5 750 CPU gives:
> 
> coretemp: Unknown CPU model 1e
> coretemp: Unknown CPU model 1e
> coretemp: Unknown CPU model 1e
> coretemp: Unknown CPU model 1e
> 
> Looks like this model needs to be added to the list in 
> drivers/hwmon/coretemp.c. Though this doesn't really seem like a very 
> good approach as we'll keep having to update this driver whenever a new 
> CPU model gets released. Intel has a CPUID field that indicates if the 
> thermal sensor is supported: "The processor supports a digital thermal 
> sensor if CPUID.06H.EAX[0] = 1." We should likely be using this instead 
> of hard-coded CPU model checks..

Supporting the digital thermal sensor is one thing, but it is totally
insufficient. If you look at the coretemp driver, you'll see we need to
figure out a number of calibration values which are model-dependent. So
we will need to check this part before adding support for new CPU
models anyway.

-- 
Jean Delvare
http://khali.linux-fr.org/wishlist.html

  parent reply	other threads:[~2009-09-20 19:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-20  7:47 coretemp support for Core i5 CPU Robert Hancock
2009-09-20 18:19 ` [PATCH] coretemp: add " Robert Hancock
2009-09-23 21:19   ` Jean Delvare
2009-09-20 19:16 ` Jean Delvare [this message]
2009-09-20 22:53   ` [lm-sensors] coretemp " Robert Hancock
2009-09-21  7:50     ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090920211620.1c18d7fb@hyperion.delvare \
    --to=khali@linux-fr.org \
    --cc=hancockrwd@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox