public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Greg KH <gregkh@suse.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, Kay Sievers <kay.sievers@vrfy.org>,
	"Eric W. Biederman" <ebiederm@xmission.com>
Subject: [origin tree build fix] [PATCH] Driver-Core: extend devnode callbacks to provide permissions, fix
Date: Mon, 21 Sep 2009 09:00:55 +0200	[thread overview]
Message-ID: <20090921070055.GA14698@elte.hu> (raw)
In-Reply-To: <20090919213332.GA7668@kroah.com>


* Greg KH <gregkh@suse.de> wrote:

> Here is one driver core patch
> 
> It fixes the problem that Ingo found with devtmpfs and makes it so
> that a user can boot a kernel using devtmpfs and no version of udev
> on the system, making this option a much more useful thing.
> 
> Thanks to Ingo for reporting and testing this, and for Eric's review
> comments, which Kay has made in this patch as well.
> 
> Please pull from:
> 	master.kernel.org:/pub/scm/linux/kernel/git/gregkh/driver-core-2.6.git/
[...]
>
> Kay Sievers (1):
>       Driver-Core: extend devnode callbacks to provide permissions

Looks good here - except that you missed a driver which broke the 
upstream build - fix patch attached below.

Thanks,

	Ingo

------------------>
>From 7a9906a8f51df1bf30789aa7c74609928ddb8d0e Mon Sep 17 00:00:00 2001
From: Ingo Molnar <mingo@elte.hu>
Date: Mon, 21 Sep 2009 08:56:58 +0200
Subject: [PATCH] Driver-Core: extend devnode callbacks to provide permissions, fix

The build of the dabusb driver broke:

  drivers/media/video/dabusb.c:758: error: unknown field 'nodename' specified in initializer
  drivers/media/video/dabusb.c:758: warning: initialization from incompatible pointer type
  make[3]: *** wait: No child processes.  Stop.

Due to this commit:

  e454cea: Driver-Core: extend devnode callbacks to provide permissions

Missing the dabusb driver's dabusb_nodename() callback.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 drivers/media/video/dabusb.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/video/dabusb.c b/drivers/media/video/dabusb.c
index 0664d11..ee43876 100644
--- a/drivers/media/video/dabusb.c
+++ b/drivers/media/video/dabusb.c
@@ -748,14 +748,14 @@ static const struct file_operations dabusb_fops =
 	.release =	dabusb_release,
 };
 
-static char *dabusb_nodename(struct device *dev)
+static char *dabusb_devnode(struct device *dev, mode_t *mode)
 {
 	return kasprintf(GFP_KERNEL, "usb/%s", dev_name(dev));
 }
 
 static struct usb_class_driver dabusb_class = {
 	.name =		"dabusb%d",
-	.nodename =	dabusb_nodename,
+	.devnode =	dabusb_devnode,
 	.fops =		&dabusb_fops,
 	.minor_base =	DABUSB_MINOR,
 };


  parent reply	other threads:[~2009-09-21  7:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-19 21:33 [GIT PATCH] driver core patch for 2.6.31-git Greg KH
2009-09-19 21:36 ` [PATCH 1/1] Driver-Core: extend devnode callbacks to provide permissions Greg Kroah-Hartman
2009-09-21  7:00 ` Ingo Molnar [this message]
2009-09-21 13:07   ` [origin tree build fix] [PATCH] Driver-Core: extend devnode callbacks to provide permissions, fix Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090921070055.GA14698@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=gregkh@suse.de \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox