public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <jens.axboe@oracle.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	jack@suse.cz, fengguang.wu@intel.com
Subject: Re: [GIT PULL] a few writeback fixes
Date: Mon, 21 Sep 2009 21:02:19 +0200	[thread overview]
Message-ID: <20090921190219.GD23126@kernel.dk> (raw)
In-Reply-To: <20090921164236.GA4398@elte.hu>

On Mon, Sep 21 2009, Ingo Molnar wrote:
> 
> * Jens Axboe <jens.axboe@oracle.com> wrote:
> 
> > Hi Linus,
> > 
> > This fixes a problem with NFS killing its bdi without being 
> > initialized, and also contains a fix for a busy loop (where we forgot 
> > to set the task state before sleeping). Since these are a bit critical 
> > for -rc1, I'm pushing them out before leaving for Portland.
> > 
> > Jan, since we're not really sure on the inode wait yet, I dropped that 
> > patch. It's definitely something to look into, as are the congestion 
> > bits.
> > 
> > I plan on adding some writeback tracing code while on the plane for 
> > further analysis when I get back.
> > 
> >   git://git.kernel.dk/linux-2.6-block.git writeback
> > 
> > Jens Axboe (4):
> >       nfs: nfs_kill_super() should call bdi_unregister() after killing super
> >       writeback: don't use schedule_timeout() without setting runstate
> >       writeback: make balance_dirty_pages() gradually back more off
> >       nfs: initialize the backing_dev_info when creating the server
> > 
> >  fs/nfs/client.c     |   10 ++++++----
> >  fs/nfs/super.c      |    2 +-
> >  mm/page-writeback.c |   11 ++++++++++-
> >  3 files changed, 17 insertions(+), 6 deletions(-)
> 
> just an update about the BDI slab corruption bugs i reported in this 
> thread on lkml:
> 
>    [origin tree SLAB corruption] BUG kmalloc-64: Poison overwritten,
>         INFO: Allocated in bdi_alloc_work+0x2b/0x100 age=175 cpu=1 pid=3514
> 
> They have gone away entirely with your earlier BDI fixes/updates, on all 
> -tip testsystems that triggered it. So that bug can be closed for good.

That's good, I was expecting Nicks fixes to resolve those. Thanks for
confirming!

-- 
Jens Axboe


      reply	other threads:[~2009-09-21 19:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-21 12:56 [GIT PULL] a few writeback fixes Jens Axboe
2009-09-21 13:08 ` Wu Fengguang
2009-09-21 13:11 ` Jan Kara
2009-09-21 13:41   ` Jens Axboe
2009-09-21 16:42 ` Ingo Molnar
2009-09-21 19:02   ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090921190219.GD23126@kernel.dk \
    --to=jens.axboe@oracle.com \
    --cc=fengguang.wu@intel.com \
    --cc=jack@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox