From: Stephen Hemminger <shemminger@vyatta.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Len Brown <len.brown@intel.com>,
Matt Helsley <matthltc@us.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-pm@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] make refrigerator cold
Date: Tue, 22 Sep 2009 14:09:14 -0700 [thread overview]
Message-ID: <20090922140914.041b7328@s6510> (raw)
In-Reply-To: <200909222154.09726.rjw@sisk.pl>
On Tue, 22 Sep 2009 21:54:09 +0200
"Rafael J. Wysocki" <rjw@sisk.pl> wrote:
> On Tuesday 22 September 2009, Stephen Hemminger wrote:
> > By marking it cold, then the code path in kernel thread
> > usage of try_to_freeze() that is normally used be
> > selected.
>
In the code for try_to_freeze(), for optimization, it might
help to tell the compiler to not favor the code path where
the refigrator is being called.
Another way to do the same thing would be to do.
if (unlikely(freezing(current))) {
refrigerator();
return 1;
} else
return 0;
or build unlikely into the freezing function (see need_resched).
I saw this by trying to minimize the number of intstructions
in pktgen which is a special case.
next prev parent reply other threads:[~2009-09-22 21:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090921210416.1982bcab@nehalam>
2009-09-22 19:54 ` [PATCH] make refrigerator cold Rafael J. Wysocki
2009-09-22 21:09 ` Stephen Hemminger [this message]
2009-09-22 23:13 ` Rafael J. Wysocki
2009-09-22 23:19 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090922140914.041b7328@s6510 \
--to=shemminger@vyatta.com \
--cc=akpm@linux-foundation.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=matthltc@us.ibm.com \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox