public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: "Am?rico Wang" <xiyou.wangcong@gmail.com>,
	Caveh Jalali <ecaveh@gmail.com>,
	linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] warn about use of uninstalled kernel headers
Date: Tue, 22 Sep 2009 15:09:47 +0200	[thread overview]
Message-ID: <200909221509.47369.arnd@arndb.de> (raw)
In-Reply-To: <20090922044310.GA29208@merkur.ravnborg.org>

On Tuesday 22 September 2009, Sam Ravnborg wrote:
> > +#ifndef __EXPORTED_HEADERS__
> But why do we need this "__EXPORTED_HEADERS__" thing?
> 
> ?

The problem is that the warning should only be for headers
that are not installed yet, but it needs to be stripped
in the installed version. Since we're already postprocessing
all files with unifdef, that seemed like the easiest way 
to strip out the #warning. Obviously, I couldn't use the
#ifdef __KERNEL__ logic, because that would either warn
give false positives when building kernel code or when
building user code from installed headers.

	Arnd <><

  reply	other threads:[~2009-09-22 13:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-17  2:30 [patch] Makefile: can't build modules outside the kernel tree if it was built using O= Caveh Jalali
2009-09-17  3:15 ` Américo Wang
2009-09-17  4:40 ` Caveh Jalali
2009-09-17 11:45 ` Arnd Bergmann
2009-09-17 21:49   ` Caveh Jalali
2009-09-18  9:28     ` Arnd Bergmann
2009-09-18 11:15     ` Arnd Bergmann
2009-09-18  1:49   ` Américo Wang
2009-09-18  4:52     ` Sam Ravnborg
2009-09-21 14:37       ` [PATCH] warn about use of uninstalled kernel headers Arnd Bergmann
2009-09-22  4:43         ` Sam Ravnborg
2009-09-22 13:09           ` Arnd Bergmann [this message]
2009-09-27  8:44         ` Sam Ravnborg
2009-09-19  9:06 ` [patch] Makefile: can't build modules outside the kernel tree if it was built using O= Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200909221509.47369.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=ecaveh@gmail.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox