public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] virtio-blk: add support for cache flush
Date: Tue, 22 Sep 2009 16:04:41 +0930	[thread overview]
Message-ID: <200909221604.41838.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20090917175742.GA2416@lst.de>

On Fri, 18 Sep 2009 03:27:42 am Christoph Hellwig wrote:
> 
> Recent qemu has added a VIRTIO_BLK_F_FLUSH flag to advertise that the
> virtual disk has a volatile write cache that needs to be flushed.  In case
> we see this feature implement tell the Linux block layer about the fact
> and use the new VIRTIO_BLK_T_FLUSH to flush the cache when required.  This
> allows for an correct and simple implementation of write barriers.

Thanks Christoph, this looks very nice.  Applied, will push soon.

> + *   VIRTIO_BLK_T_OUT may be combinaed with VIRTIO_BLK_T_SCSI_CMD or
> + *   VIRTIO_BLK_T_BARRIER.  VIRTIO_BLK_T_FLUSH is a command of it's own
> + *   and may no be comined with any of the other flags.

I fixed the typos here :)

Thanks!
Rusty.

      reply	other threads:[~2009-09-22  6:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-17 17:57 [PATCH] virtio-blk: add support for cache flush Christoph Hellwig
2009-09-22  6:34 ` Rusty Russell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200909221604.41838.rusty@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox