From: Rusty Russell <rusty@rustcorp.com.au>
To: "Jan Beulich" <JBeulich@novell.com>
Cc: linux-kernel@vger.kernel.org, Ben Elliston <bje@air.net.au>
Subject: Re: [PATCH] fix BUILD_BUG_ON() and a couple of bogus uses of it
Date: Tue, 22 Sep 2009 16:15:30 +0930 [thread overview]
Message-ID: <200909221615.31334.rusty@rustcorp.com.au> (raw)
In-Reply-To: <4A8AEBFD0200007800010580@vpn.id2.novell.com>
On Wed, 19 Aug 2009 01:29:25 am Jan Beulich wrote:
> Note that in the gfp.h, kmemcheck.h, and virtio_config.h cases
> MAYBE_BUILD_BUG_ON() really just serves documentation purposes - even
> if the expression is compile time constant (__builtin_constant_p()
> yields true), the array is still deemed of variable length by gcc, and
> hence the whole expression doesn't have the intended effect.
How annoying. A gcc build assert extension would be great here?
Thanks,
Rusty.
next prev parent reply other threads:[~2009-09-22 6:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-18 15:59 [PATCH] fix BUILD_BUG_ON() and a couple of bogus uses of it Jan Beulich
2009-09-17 23:24 ` Andrew Morton
2009-09-18 0:01 ` David Miller
2009-09-18 0:15 ` Andrew Morton
2009-09-18 0:18 ` Andrew Morton
2009-09-18 0:31 ` David Miller
2009-09-18 0:45 ` David Miller
2009-09-22 6:45 ` Rusty Russell [this message]
2009-09-23 0:57 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200909221615.31334.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=JBeulich@novell.com \
--cc=bje@air.net.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox