From: Frederic Weisbecker <fweisbec@gmail.com>
To: Anton Blanchard <anton@samba.org>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Li Zefan <lizf@cn.fujitsu.com>, Zhaolei <zhaolei@cn.fujitsu.com>,
Lai Jiangshan <laijs@cn.fujitsu.com>, Ingo Molnar <mingo@elte.hu>,
Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] tracing/workqueue: Use %pf in workqueue trace events
Date: Tue, 22 Sep 2009 22:35:15 +0200 [thread overview]
Message-ID: <20090922203513.GB5059@nowhere> (raw)
In-Reply-To: <20090922024033.GB31801@kryten>
On Tue, Sep 22, 2009 at 12:40:33PM +1000, Anton Blanchard wrote:
>
> Using %pf instead of %pF supresses printing of the function offset
> which will always be 0.
>
> Signed-off-by: Anton Blanchard <anton@samba.org>
I'll queue this one, thanks!
> ---
>
> Index: linux.trees.git/include/trace/events/workqueue.h
> ===================================================================
> --- linux.trees.git.orig/include/trace/events/workqueue.h 2009-09-01 15:11:04.000000000 +1000
> +++ linux.trees.git/include/trace/events/workqueue.h 2009-09-14 09:45:41.000000000 +1000
> @@ -26,7 +26,7 @@ TRACE_EVENT(workqueue_insertion,
> __entry->func = work->func;
> ),
>
> - TP_printk("thread=%s:%d func=%pF", __entry->thread_comm,
> + TP_printk("thread=%s:%d func=%pf", __entry->thread_comm,
> __entry->thread_pid, __entry->func)
> );
>
> @@ -48,7 +48,7 @@ TRACE_EVENT(workqueue_execution,
> __entry->func = work->func;
> ),
>
> - TP_printk("thread=%s:%d func=%pF", __entry->thread_comm,
> + TP_printk("thread=%s:%d func=%pf", __entry->thread_comm,
> __entry->thread_pid, __entry->func)
> );
>
next prev parent reply other threads:[~2009-09-22 20:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-22 2:39 [PATCH 0/2] tracing/workqueue fixes Anton Blanchard
2009-09-22 2:40 ` [PATCH 1/2] tracing/workqueue: Use %pf in workqueue trace events Anton Blanchard
2009-09-22 2:42 ` [PATCH 2/2] tracing/workqueue: Rename workqueue_execute to worklet_entry and add worklet_exit Anton Blanchard
2009-09-22 20:34 ` Frederic Weisbecker
2009-09-24 0:22 ` KOSAKI Motohiro
2009-09-22 20:35 ` Frederic Weisbecker [this message]
2009-09-23 9:04 ` [tip:tracing/urgent] tracing/workqueue: Use %pf in workqueue trace events tip-bot for Anton Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090922203513.GB5059@nowhere \
--to=fweisbec@gmail.com \
--cc=anton@samba.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=zhaolei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox