From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: Len Brown <len.brown@intel.com>,
Matt Helsley <matthltc@us.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-pm@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] make refrigerator cold
Date: Tue, 22 Sep 2009 21:54:09 +0200 [thread overview]
Message-ID: <200909222154.09726.rjw@sisk.pl> (raw)
In-Reply-To: <20090921210416.1982bcab@nehalam>
On Tuesday 22 September 2009, Stephen Hemminger wrote:
> By marking it cold, then the code path in kernel thread
> usage of try_to_freeze() that is normally used be
> selected.
The sentence above isn't very clear IMO, could you please rephrase?
> Don't think it matters that much for performance but the
> concordance of this patch struck me as humorous.
Well, yeah.
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
>
>
> --- a/include/linux/freezer.h 2009-09-21 20:34:17.579233461 -0700
> +++ b/include/linux/freezer.h 2009-09-21 20:35:25.724322028 -0700
> @@ -47,7 +47,7 @@ static inline bool should_send_signal(st
> /* Takes and releases task alloc lock using task_lock() */
> extern int thaw_process(struct task_struct *p);
>
> -extern void refrigerator(void);
> +extern void refrigerator(void) __cold;
> extern int freeze_processes(void);
> extern void thaw_processes(void);
next parent reply other threads:[~2009-09-22 19:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090921210416.1982bcab@nehalam>
2009-09-22 19:54 ` Rafael J. Wysocki [this message]
2009-09-22 21:09 ` [PATCH] make refrigerator cold Stephen Hemminger
2009-09-22 23:13 ` Rafael J. Wysocki
2009-09-22 23:19 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200909222154.09726.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=akpm@linux-foundation.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=matthltc@us.ibm.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox