From: Arjan van de Ven <arjan@infradead.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org,
Frederic Weisbecker <fweisbec@gmail.com>,
mingo@elte.hu
Subject: [patch] introduce TRACE_EVENT_ABI (was Re: TRACE_EVENT_ABI ?)
Date: Wed, 23 Sep 2009 10:32:44 +0200 [thread overview]
Message-ID: <20090923103244.7aa5d027@infradead.org> (raw)
In-Reply-To: <1253568031.2935.5.camel@frodo>
On Mon, 21 Sep 2009 17:20:31 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Mon, 2009-09-21 at 20:00 +0200, Arjan van de Ven wrote:
> > On Mon, 21 Sep 2009 12:46:07 -0400
> > Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> > > On Mon, 2009-09-21 at 15:28 +0200, Arjan van de Ven wrote:
>
> > > This patch compiled for me;
> > >
> >
> > your magic skills exceed mine ;-)
> >
> > mind sending me a signoff for this ?
>
> Sure,
>
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
>From e2c647ae2d3ddc25b804f0419956caf40d89c606 Mon Sep 17 00:00:00 2001
From: Steven Rostedt <rostedt@goodmis.org>
Date: Mon, 21 Sep 2009 20:14:53 +0200
Subject: [PATCH] trace: introduce TRACE_EVENT_ABI
Some trace events are suitable to form a stable userspace ABI;
this patch introduces infrastructure to mark them as such,
and marks the first few tracepoints this way
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
---
include/linux/tracepoint.h | 4 ++++
include/trace/events/power.h | 6 +++---
include/trace/events/sched.h | 4 ++--
3 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/include/linux/tracepoint.h b/include/linux/tracepoint.h
index 63a3f7a..4cb454f 100644
--- a/include/linux/tracepoint.h
+++ b/include/linux/tracepoint.h
@@ -280,6 +280,10 @@ static inline void tracepoint_synchronize_unregister(void)
* TRACE_EVENT_FN to perform any (un)registration work.
*/
+#define TRACE_EVENT_ABI(name, proto, args, tstruct, assign, print) \
+ TRACE_EVENT(name, PARAMS(proto), PARAMS(args), \
+ PARAMS(tstruct), PARAMS(assign), PARAMS(print))
+
#define TRACE_EVENT(name, proto, args, struct, assign, print) \
DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
#define TRACE_EVENT_FN(name, proto, args, struct, \
diff --git a/include/trace/events/power.h b/include/trace/events/power.h
index ea6d579..7f0e86e 100644
--- a/include/trace/events/power.h
+++ b/include/trace/events/power.h
@@ -18,7 +18,7 @@ enum {
-TRACE_EVENT(power_start,
+TRACE_EVENT_ABI(power_start,
TP_PROTO(unsigned int type, unsigned int state),
@@ -37,7 +37,7 @@ TRACE_EVENT(power_start,
TP_printk("type=%lu state=%lu", (unsigned long)__entry->type, (unsigned long)__entry->state)
);
-TRACE_EVENT(power_end,
+TRACE_EVENT_ABI(power_end,
TP_PROTO(int dummy),
@@ -56,7 +56,7 @@ TRACE_EVENT(power_end,
);
-TRACE_EVENT(power_frequency,
+TRACE_EVENT_ABI(power_frequency,
TP_PROTO(unsigned int type, unsigned int state),
diff --git a/include/trace/events/sched.h b/include/trace/events/sched.h
index 4069c43..93a3e17 100644
--- a/include/trace/events/sched.h
+++ b/include/trace/events/sched.h
@@ -83,7 +83,7 @@ TRACE_EVENT(sched_wait_task,
* (NOTE: the 'rq' argument is not used by generic trace events,
* but used by the latency tracer plugin. )
*/
-TRACE_EVENT(sched_wakeup,
+TRACE_EVENT_ABI(sched_wakeup,
TP_PROTO(struct rq *rq, struct task_struct *p, int success),
@@ -149,7 +149,7 @@ TRACE_EVENT(sched_wakeup_new,
* (NOTE: the 'rq' argument is not used by generic trace events,
* but used by the latency tracer plugin. )
*/
-TRACE_EVENT(sched_switch,
+TRACE_EVENT_ABI(sched_switch,
TP_PROTO(struct rq *rq, struct task_struct *prev,
struct task_struct *next),
--
1.6.0.6
--
Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
next prev parent reply other threads:[~2009-09-23 8:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-21 7:36 TRACE_EVENT_ABI ? Arjan van de Ven
2009-09-21 12:42 ` Steven Rostedt
2009-09-21 13:26 ` Steven Rostedt
2009-09-21 13:28 ` Arjan van de Ven
2009-09-21 16:46 ` Steven Rostedt
2009-09-21 17:58 ` Frederic Weisbecker
2009-09-21 18:00 ` Arjan van de Ven
2009-09-21 21:20 ` Steven Rostedt
2009-09-23 8:32 ` Arjan van de Ven [this message]
2009-09-23 10:57 ` [patch] introduce TRACE_EVENT_ABI (was Re: TRACE_EVENT_ABI ?) Frédéric Weisbecker
-- strict thread matches above, loose matches on Subject: below --
2009-09-23 12:43 Christoph Hellwig
2009-09-23 14:03 ` Steven Rostedt
2009-09-23 14:07 ` Christoph Hellwig
2009-09-23 15:38 ` Ingo Molnar
2009-09-23 16:16 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090923103244.7aa5d027@infradead.org \
--to=arjan@infradead.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox