* Re: [Bugme-new] [Bug 14222] New: Hibernation oopses for the 2nd time with 2.6.31 (won't fit the screen)
[not found] <bug-14222-10286@http.bugzilla.kernel.org/>
@ 2009-09-24 22:26 ` Andrew Morton
0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2009-09-24 22:26 UTC (permalink / raw)
To: linux
Cc: bugzilla-daemon, bugme-daemon, linux-kernel, john stultz,
Paul Mundt, Ingo Molnar, Rafael J. Wysocki, stable, Magnus Damm
On Thu, 24 Sep 2009 14:07:09 GMT
bugzilla-daemon@bugzilla.kernel.org wrote:
> http://bugzilla.kernel.org/show_bug.cgi?id=14222
>
> Summary: Hibernation oopses for the 2nd time with 2.6.31 (won't
> fit the screen)
> Product: Timers
> Version: 2.5
> Kernel Version: 2.6.31
> Platform: All
> OS/Version: Linux
> Tree: Mainline
> Status: NEW
> Severity: normal
> Priority: P1
> Component: Other
> AssignedTo: johnstul@us.ibm.com
> ReportedBy: linux@rainbow-software.org
> Regression: Yes
It's a 2.6.21 regression.
>
> Hibernation worked great with 2.6.30 - I had over a month of uptime (it never
> worked so well before - always crashed after some time). But in 2.6.31, it's
> broken again - and completely. The first hibernation works but it always
> crashes on the second one.
>
> The oops won't fit the screen, even 1280x1024 is not enough.
>
> I bisected it and found this:
Thanks for bisecting it.
> c7121843685de2bf7f3afd3ae1d6a146010bf1fc is first bad commit
> commit c7121843685de2bf7f3afd3ae1d6a146010bf1fc
> Author: Magnus Damm <magnus.damm@gmail.com>
> Date: __ Tue Jul 28 14:09:55 2009 -0700
>
> __ __ clocksource: Save mult_orig in clocksource_disable()
>
> __ __ To fix the common case where ->enable() does not set up
> __ __ mult, make sure mult_orig is saved in mult on disable.
>
> __ __ Also add comments to explain why we do this.
>
> __ __ Signed-off-by: Magnus Damm <damm@igel.co.jp>
> __ __ Cc: johnstul@us.ibm.com
> __ __ Cc: lethal@linux-sh.org
> __ __ Cc: akpm@linux-foundation.org
> __ __ LKML-Reference: <20090618152432.10136.9932.sendpatchset@rx1.opensource.se>
> __ __ Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
>
> :040000 040000 c965062bc79af46cdb3522fc7ab1cc81d2f84de3
> 26616c88a8128b25fd15c3da39ac6251cd9723b6 M __ __ __include
>
> Reverting this commit fixes the problem.
OK, I cc'ed everyone.
Guys, is reverting this patch the best approach?
It might be for 2.6.31.x but not for 2.6.32, perhaps?
^ permalink raw reply [flat|nested] only message in thread