Re: [PATCH v18 20/80] c/r: basic infrastructure for checkpoint/restart

Daniel Walker
2009-09-24T16:03:53Z

On Wed, 2009-09-23 at 19:51 -0400, Oren Laadan wrote:
> /
> +static char *__ckpt_generate_fmt(struct ckpt_ctx *ctx, char *prefmt, char *fmt)
> +{
> + static int warn_notask = 0;
> + static int warn_prefmt = 0;

Shouldn't need the initializer since it's static..

> +/* read the checkpoint header */
> +static int restore_read_header(struct ckpt_ctx *ctx)
> +{
> + struct ckpt_hdr_header *h;
> + struct new_utsname *uts = NULL;
> + int ret;
> +
> + h = ckpt_read_obj_type(ctx, sizeof(*h), CKPT_HDR_HEADER);
> + if (IS_ERR(h))
> + return PTR_ERR(h);
> +
> + ret = -EINVAL;
> + if (h->magic != CHECKPOINT_MAGIC_HEAD ||
> + h->rev != CHECKPOINT_VERSION ||
> + h->major != ((LINUX_VERSION_CODE >> 16) & 0xff) ||
> + h->minor != ((LINUX_VERSION_CODE >> 8) & 0xff) ||
> + h->patch != ((LINUX_VERSION_CODE) & 0xff))
> + goto out;

Do you still need this LINUX_VERSION_CODE stuff ? I would think once
it's in mainline you wouldn't need to track that..

These both got flagged by checkpatch .. Your series is marked in a
couple other places with checkpatch errors .. If you haven't already
reviewed those errors, it would be a good idea to review them.

Daniel