Re: [PATCH: kvm 4/5] Fix hotremove of CPUs for KVM.

Zachary Amsden
2009-09-28T01:44:56Z

On 09/26/2009 10:54 PM, Avi Kivity wrote:
>
> First, I'm not sure per_cpu works for possible but not actual cpus.
> Second, we now eagerly allocate but lazily free, leading to lots of
> ifs and buts. I think the code can be cleaner by eagerly allocating
> and eagerly freeing.

Eager freeing requires a hotplug remove notification to the arch layer.
I had done that originally, but not sure.

How does per_cpu() work when defined in a module anyway? The linker
magic going on here evades a simple one-minute analysis.

Zach