Re: [GIT PULL v2] bkl tracepoints + filter regex support

[Ingo Molnar <mingo@elte.hu>]

* Ingo Molnar <mingo@elte.hu> wrote:

> 
> * Frederic Weisbecker <fweisbec@gmail.com> wrote:
> 
> > Ingo,
> > 
> > This is new iteration of the bkl tracepoints + filter
> > regex support. It addresses the reviews that were posted
> > in the previous RFC version.
> > 
> > Please pull from:
> > 
> > git://git.kernel.org/pub/scm/linux/kernel/git/frederic/random-tracing.git
> > 	tracing/core
> > 
> > Thanks;
> > Frederic.
> > 
> > Frederic Weisbecker (5):
> >       tracing/bkl: Add bkl ftrace events
> >       tracing/filters: Cleanup useless headers
> >       tracing/event: Cleanup the useless dentry variable
> >       tracing/filters: Provide basic regex support
> >       tracing/filters: Unify the regex parsing helpers
> > 
> >  include/linux/smp_lock.h           |   19 ++++-
> >  include/trace/events/bkl.h         |   61 ++++++++++++++
> >  kernel/trace/ftrace.c              |   64 +--------------
> >  kernel/trace/trace.h               |   36 ++++++--
> >  kernel/trace/trace_events.c        |   23 +++---
> >  kernel/trace/trace_events_filter.c |  155 +++++++++++++++++++++++++++++++----
> >  lib/kernel_lock.c                  |   11 ++-
> >  7 files changed, 262 insertions(+), 107 deletions(-)
> >  create mode 100644 include/trace/events/bkl.h
> 
> Pulled, thanks a lot Frederic! These bits look very useful.
> 
> It would be perf-ect now to complete the filters-via-perf-events changes 
> Li Zefan is working on ;-)

There's one thing Peter noticed: this is not C syntax anymore. It would 
be really nice to keep filter expressions a subset of C.

	Ingo