* [PATCH] nommu: Correct is_vmamloc_or_module_addr() definition.
@ 2009-09-25 3:07 Paul Mundt
2009-09-25 3:08 ` KAMEZAWA Hiroyuki
0 siblings, 1 reply; 3+ messages in thread
From: Paul Mundt @ 2009-09-25 3:07 UTC (permalink / raw)
To: Linus Torvalds; +Cc: KAMEZAWA Hiroyuki, linux-kernel
Commit 81ac3ad9061dd9cd490ee92f0c5316a14d77ce18 broke the nommu build
due to is_vmalloc_or_module_addr() not being marked inline. Fix it up.
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
---
include/linux/mm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/mm.h b/include/linux/mm.h
index b6eae5e..23e7fd6 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -288,7 +288,7 @@ static inline int is_vmalloc_addr(const void *x)
#ifdef CONFIG_MMU
extern int is_vmalloc_or_module_addr(const void *x);
#else
-static int is_vmalloc_or_module_addr(const void *x)
+static inline int is_vmalloc_or_module_addr(const void *x)
{
return 0;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] nommu: Correct is_vmamloc_or_module_addr() definition.
2009-09-25 3:07 [PATCH] nommu: Correct is_vmamloc_or_module_addr() definition Paul Mundt
@ 2009-09-25 3:08 ` KAMEZAWA Hiroyuki
2009-09-25 3:12 ` Paul Mundt
0 siblings, 1 reply; 3+ messages in thread
From: KAMEZAWA Hiroyuki @ 2009-09-25 3:08 UTC (permalink / raw)
To: Paul Mundt; +Cc: Linus Torvalds, linux-kernel, akpm
On Fri, 25 Sep 2009 12:07:06 +0900
Paul Mundt <lethal@linux-sh.org> wrote:
> Commit 81ac3ad9061dd9cd490ee92f0c5316a14d77ce18 broke the nommu build
> due to is_vmalloc_or_module_addr() not being marked inline. Fix it up.
>
> Signed-off-by: Paul Mundt <lethal@linux-sh.org>
> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
>
Ah, sorry. I think Andrew queues the same patch.
Thanks,
-Kame
> ---
>
> include/linux/mm.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index b6eae5e..23e7fd6 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -288,7 +288,7 @@ static inline int is_vmalloc_addr(const void *x)
> #ifdef CONFIG_MMU
> extern int is_vmalloc_or_module_addr(const void *x);
> #else
> -static int is_vmalloc_or_module_addr(const void *x)
> +static inline int is_vmalloc_or_module_addr(const void *x)
> {
> return 0;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nommu: Correct is_vmamloc_or_module_addr() definition.
2009-09-25 3:08 ` KAMEZAWA Hiroyuki
@ 2009-09-25 3:12 ` Paul Mundt
0 siblings, 0 replies; 3+ messages in thread
From: Paul Mundt @ 2009-09-25 3:12 UTC (permalink / raw)
To: KAMEZAWA Hiroyuki; +Cc: Linus Torvalds, linux-kernel, akpm
On Fri, Sep 25, 2009 at 12:08:30PM +0900, KAMEZAWA Hiroyuki wrote:
> On Fri, 25 Sep 2009 12:07:06 +0900
> Paul Mundt <lethal@linux-sh.org> wrote:
>
> > Commit 81ac3ad9061dd9cd490ee92f0c5316a14d77ce18 broke the nommu build
> > due to is_vmalloc_or_module_addr() not being marked inline. Fix it up.
> >
> > Signed-off-by: Paul Mundt <lethal@linux-sh.org>
> > Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> >
> Ah, sorry. I think Andrew queues the same patch.
>
Ah, I'm too slow, David already caught it:
commit 934831d060ccd5471ecbc562804a8d3ccd6e562c
Author: David Howells <dhowells@redhat.com>
Date: Thu Sep 24 12:33:32 2009 +0100
NOMMU: Fallback for is_vmalloc_or_module_addr() should be inline
The NOMMU fallback for is_vmalloc_or_module_addr() should be static inline,
not just static, in linux/mm.h.
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Sorry for the noise!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-09-25 3:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-25 3:07 [PATCH] nommu: Correct is_vmamloc_or_module_addr() definition Paul Mundt
2009-09-25 3:08 ` KAMEZAWA Hiroyuki
2009-09-25 3:12 ` Paul Mundt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox