Re: [PATCH] Add missing blk_trace_remove_sysfs to be in pair with blk_trace_init_sysfs

Zdenek Kabelac
2009-09-22T07:57:53Z

2009/9/22 Li Zefan <lizf@cn.fujitsu.com>:
> Zdenek Kabelac wrote:
>> Subject: [PATCH] Add missing blk_trace_remove_sysfs to be in pair with
>> blk_trace_init_sysfs
>> From: Zdenek Kabelac <zkabelac@redhat.com>
>>
>> Adds missing blk_trace_remove_sysfs() to be in pair with
>> blk_trace_init_sysfs() introduced in commit
>> 1d54ad6da9192fed5dd3b60224d9f2dfea0dcd82.
>>
>> Problem was noticed via kmemleak backtrace when some sysfs entries
>> were note properly destroyed during  device removal:
>>
>
> Thanks for reporting and fixing this!
>
>> @@ -465,6 +466,7 @@ void blk_unregister_queue(struct gendisk *disk)
>>
>>               kobject_uevent(&q->kobj, KOBJ_REMOVE);
>>               kobject_del(&q->kobj);
>> +             blk_trace_remove_sysfs(disk_to_dev(disk));
>
> This should be moved outside of 'if'.
>

I was not really sure about the proper place - if it could be placed
before if() or after the if(){} - as I've not checked in depth
connection between kobj and sysfs. It's somewhat unclear why all the
kobject operation are only within this if(){} block - so I've thought
there is some reason...
IMHO only elv_unregister_queue() should be probably in the if(){} block.

Feel free to update/fix.

Zdenek