Re: [PATCH] Add missing blk_trace_remove_sysfs to be in pair with blk_trace_init_sysfs

Li Zefan
2009-09-22T06:10:20Z

Zdenek Kabelac wrote:
> Subject: [PATCH] Add missing blk_trace_remove_sysfs to be in pair with
> blk_trace_init_sysfs
> From: Zdenek Kabelac <zkabelac@redhat.com>
>
> Adds missing blk_trace_remove_sysfs() to be in pair with
> blk_trace_init_sysfs() introduced in commit
> 1d54ad6da9192fed5dd3b60224d9f2dfea0dcd82.
>
> Problem was noticed via kmemleak backtrace when some sysfs entries
> were note properly destroyed during device removal:
>

Thanks for reporting and fixing this!

> @@ -465,6 +466,7 @@ void blk_unregister_queue(struct gendisk *disk)
>
> kobject_uevent(&q->kobj, KOBJ_REMOVE);
> kobject_del(&q->kobj);
> + blk_trace_remove_sysfs(disk_to_dev(disk));

This should be moved outside of 'if'.

> kobject_put(&disk_to_dev(disk)->kobj);
> }
> }