From: "Andrey Panin" <pazke@centrinvest.ru>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Tom Zanussi <tzanussi@gmail.com>, Li Zefan <lizf@cn.fujitsu.com>
Subject: Re: [PATCH 4/5 v2] tracing/filters: Provide basic regex support
Date: Fri, 25 Sep 2009 12:13:45 +0400 [thread overview]
Message-ID: <20090925081345.GA9236@centrinvest.ru> (raw)
In-Reply-To: <1253821775-8618-5-git-send-email-fweisbec@gmail.com>
On 267, 09 24, 2009 at 09:49:34PM +0200, Frederic Weisbecker wrote:
> This patch provides basic support for regular expressions in filters.
> +/* Basic regex callbacks */
> +static int regex_match_full(char *str, struct regex *r, int len)
> +{
> + if (strncmp(str, r->pattern, len) == 0)
> + return 1;
> + return 0;
> +}
> +
> +static int regex_match_front(char *str, struct regex *r, int len)
> +{
> + if (strncmp(str, r->pattern, len) == 0)
> + return 1;
> + return 0;
> +}
These two functions are identical, what's the reason to keep them separate ?
And why not simply return strncmp(str, r->pattern, len) == 0 ?
next prev parent reply other threads:[~2009-09-25 8:13 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-24 19:49 [GIT PULL v2] bkl tracepoints + filter regex support Frederic Weisbecker
2009-09-24 19:49 ` [PATCH 1/5 v2] tracing/bkl: Add bkl ftrace events Frederic Weisbecker
2009-09-24 19:49 ` [PATCH 2/5 v2] tracing/filters: Cleanup useless headers Frederic Weisbecker
2009-09-24 19:49 ` [PATCH 3/5 v2] tracing/event: Cleanup the useless dentry variable Frederic Weisbecker
2009-09-24 19:49 ` [PATCH 4/5 v2] tracing/filters: Provide basic regex support Frederic Weisbecker
2009-09-25 8:13 ` Andrey Panin [this message]
2009-09-25 8:16 ` Frederic Weisbecker
2009-09-24 19:49 ` [PATCH 5/5] tracing/filters: Unify the regex parsing helpers Frederic Weisbecker
2009-09-24 20:15 ` [GIT PULL v2] bkl tracepoints + filter regex support Ingo Molnar
2009-09-24 20:16 ` Ingo Molnar
2009-09-24 20:22 ` Ingo Molnar
2009-09-25 7:55 ` Frederic Weisbecker
2009-09-24 20:30 ` Peter Zijlstra
2009-09-24 20:44 ` Frederic Weisbecker
2009-09-24 20:51 ` Peter Zijlstra
2009-09-24 21:36 ` Frederic Weisbecker
2009-09-25 8:19 ` Peter Zijlstra
2009-09-25 9:12 ` Frederic Weisbecker
2009-09-25 9:40 ` Peter Zijlstra
2009-09-25 10:38 ` Frederic Weisbecker
2009-09-26 10:44 ` Steven Rostedt
2009-10-03 11:36 ` Frederic Weisbecker
2009-09-26 15:47 ` Frank Ch. Eigler
2009-10-03 11:49 ` Frederic Weisbecker
2009-09-26 10:30 ` Steven Rostedt
2009-09-24 20:33 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090925081345.GA9236@centrinvest.ru \
--to=pazke@centrinvest.ru \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox