public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <khali@linux-fr.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	Mika Kuoppala <mika.kuoppala@nokia.com>,
	Peter Ujfalusi <peter.ujfalusi@nokia.com>
Subject: Re: [PATCH -next]  i2c: uses/select RT_MUTEXES
Date: Sat, 26 Sep 2009 11:47:40 +0200	[thread overview]
Message-ID: <20090926114740.182d8b70@hyperion.delvare> (raw)
In-Reply-To: <4ABD4213.9010700@oracle.com>

Hi Randy,

On Fri, 25 Sep 2009 15:20:03 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> i2c-core uses rt mutexes, so it needs to select that
> kconfig symbol since there is no prompt for it.
> 
> ERROR: "rt_mutex_lock" [drivers/i2c/i2c-core.ko] undefined!
> ERROR: "__rt_mutex_init" [drivers/i2c/i2c-core.ko] undefined!
> ERROR: "rt_mutex_trylock" [drivers/i2c/i2c-core.ko] undefined!
> ERROR: "rt_mutex_unlock" [drivers/i2c/i2c-core.ko] undefined!
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
>  drivers/i2c/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20090925.orig/drivers/i2c/Kconfig
> +++ linux-next-20090925/drivers/i2c/Kconfig
> @@ -5,6 +5,7 @@
>  menuconfig I2C
>  	tristate "I2C support"
>  	depends on HAS_IOMEM
> +	select RT_MUTEXES
>  	---help---
>  	  I2C (pronounce: I-square-C) is a slow serial bus protocol used in
>  	  many micro controller applications and developed by Philips.  SMBus,

Thanks for the fix, I've folded it into
i2c-prevent-priority-inversion-on-top-of-bus-lock.patch.

-- 
Jean Delvare

  reply	other threads:[~2009-09-26  9:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-25  3:38 linux-next: Tree for September 25 Stephen Rothwell
2009-09-25 13:19 ` linux-next: 20090925 - build breaks with !CONFIG_AIO Kamalesh Babulal
2009-09-26 11:37   ` Martin Schwidefsky
2009-09-25 13:31 ` linux-next: 20090925 - hvc driver build breaks with !HVC_CONSOLE Kamalesh Babulal
2009-09-25 22:20 ` [PATCH -next] i2c: uses/select RT_MUTEXES Randy Dunlap
2009-09-26  9:47   ` Jean Delvare [this message]
2009-09-25 22:20 ` [PATCH -next] input: serio_libps2 depends on serio_i8042 Randy Dunlap
2009-09-25 22:29   ` Dmitry Torokhov
2009-09-25 22:30     ` Randy Dunlap
2009-09-25 23:03 ` [PATCH -next] drbd: trace depends on TRACING Randy Dunlap
2009-09-29 15:32   ` [Drbd-dev] " Philipp Reisner
2009-09-29 15:37     ` Christoph Hellwig
2009-09-30  8:02       ` Lars Ellenberg
2009-09-30 16:00         ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090926114740.182d8b70@hyperion.delvare \
    --to=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=mika.kuoppala@nokia.com \
    --cc=peter.ujfalusi@nokia.com \
    --cc=randy.dunlap@oracle.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox