Re: [RFC][PATCH] HWPOISON: remove the unsafe __set_page_locked()

Wu Fengguang
2009-09-28T01:52:19Z

On Mon, Sep 28, 2009 at 09:19:43AM +0800, Andi Kleen wrote:
> > There is no real rush AFAIKS to fix this one single pagecache site
> > while we have problems with slab allocators and all other unaudited
> > places that nonatomically modify page flags with an elevated
>
> hwpoison ignores slab pages.
>
> > page reference ... just mark HWPOISON as broken for the moment, or
> > cut it down to do something much simpler I guess?
>
> Erm no. These cases are *EXTREMLY* unlikely to hit.
>
> I'll look into exploiting the ordering of the mapping assignment.

Andi, given that overheads of this patch is considered unacceptable,
I think we can just ignore it.

The proposed schemes are already tricky enough (and may not achieve
100% correctness). We have not even considered the interaction with
free buddy pages, unpoison, and hwpoison filtering.

It may well result in something unmanageable.

On the other hand, we may just ignore the __set_page_locked race,

- it could trigger BUG() on unlock_page(), however that's _no worse_
than plain kernel without hwpoison. Plain kernel will also die when
trying to fill data into the newly allocated pages.
- it is _not yet_ a LRU page. So it does not hurt the general idea of
"hwpoison can handle LRU pages reliably".
- in hwpoison stress testing, we can avoid such pages by checking the
PG_lru bit. Thus we can make the tests immune to this race.

Or,
- the page being __set_page_locked() is _not_ the fine LRU page
- we can prevent the kernel panic in the tests
- for a production workload, this presents merely another (rare) type
of kernel page we cannot rescue.

Thanks,
Fengguang