From: Ingo Molnar <mingo@elte.hu>
To: Len Brown <lenb@hera.kernel.org>
Cc: torvalds@linux-foundation.org, akpm@linux-foundation.org,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [origin tree build failure] [PATCH] thinkpad-acpi: Fix build on !CONFIG_THINKPAD_ACPI_HOTKEY_POLL
Date: Sun, 27 Sep 2009 09:52:54 +0200 [thread overview]
Message-ID: <20090927075254.GA20847@elte.hu> (raw)
In-Reply-To: <200909260519.n8Q5JrB6016778@hera.kernel.org>
> drivers/platform/x86/thinkpad_acpi.c | 632 +++++++++++++++++++---------
-tip testing found that these changes caused a build failure
in drivers/platform/x86/thinkpad_acpi.c when
!CONFIG_THINKPAD_ACPI_HOTKEY_POLL - the fix is attached
below.
Thanks,
Ingo
------------------------->
>From 7f6443f7238a0aa9014b11a0a31ab76825d75cdf Mon Sep 17 00:00:00 2001
From: Ingo Molnar <mingo@elte.hu>
Date: Sun, 27 Sep 2009 09:47:46 +0200
Subject: [PATCH] thinkpad-acpi: Fix build on !CONFIG_THINKPAD_ACPI_HOTKEY_POLL
This build error:
drivers/platform/x86/thinkpad_acpi.c: In function 'tpacpi_hotkey_driver_mask_set':
drivers/platform/x86/thinkpad_acpi.c:2238: error: lvalue required as left operand of assignment
Triggers because in the !CONFIG_THINKPAD_ACPI_HOTKEY_POLL case
tpacpi_hotkey_driver_mask_set ymbol is defined to a constant
literal - which is not an lvalue so cannot be assigned to.
The whole tpacpi_hotkey_driver_mask_set() function is not used
in the !CONFIG_THINKPAD_ACPI_HOTKEY_POLL, so enclose it with
an #ifdef.
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
drivers/platform/x86/thinkpad_acpi.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
index 3910f2f..a52dbc9 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -2216,6 +2216,7 @@ static int hotkey_user_mask_set(const u32 mask)
return rc;
}
+#ifdef CONFIG_THINKPAD_ACPI_HOTKEY_POLL
/*
* Sets the driver hotkey mask.
*
@@ -2244,6 +2245,7 @@ static int tpacpi_hotkey_driver_mask_set(const u32 mask)
return rc;
}
+#endif
static int hotkey_status_get(int *status)
{
next prev parent reply other threads:[~2009-09-27 7:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-26 5:19 [git pull request] ACPI related patches for 2.6.32-rc0 - part 2 Len Brown
2009-09-27 7:52 ` Ingo Molnar [this message]
2009-09-27 12:28 ` [origin tree build failure] [PATCH] thinkpad-acpi: Fix build on !CONFIG_THINKPAD_ACPI_HOTKEY_POLL Henrique de Moraes Holschuh
2009-09-28 3:34 ` Len Brown
2009-09-28 15:35 ` Ingo Molnar
2009-09-28 19:44 ` Henrique de Moraes Holschuh
2009-10-01 9:57 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090927075254.GA20847@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=lenb@hera.kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox