From: Frederic Weisbecker <fweisbec@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, mingo@redhat.com, hpa@zytor.com,
lizf@cn.fujitsu.com, tglx@linutronix.de,
linux-tip-commits@vger.kernel.org
Subject: Re: [tip:tracing/core] tracing/bkl: Add bkl ftrace events
Date: Mon, 28 Sep 2009 10:48:38 +0200 [thread overview]
Message-ID: <20090928084836.GA6142@nowhere> (raw)
In-Reply-To: <1253959554.12145.88.camel@frodo>
On Sat, Sep 26, 2009 at 06:05:54AM -0400, Steven Rostedt wrote:
> On Fri, 2009-09-25 at 06:19 +0000, tip-bot for Frederic Weisbecker
> wrote:
> > Commit-ID: 96a2c464de07d7c72988db851c029b204fc59108
>
> > +#if !defined(_TRACE_BKL_H) || defined(TRACE_HEADER_MULTI_READ)
> > +#define _TRACE_BKL_H
> > +
> > +#include <linux/tracepoint.h>
> > +
> > +TRACE_EVENT(lock_kernel,
> > +
> > + TP_PROTO(const char *func, const char *file, int line),
> > +
> > + TP_ARGS(func, file, line),
> > +
> > + TP_STRUCT__entry(
> > + __field( int, lock_depth )
>
> FYI,
>
> By your request I added this as a common field ;-)
>
> With commit:
>
> 637e7e864103a7a68c1ce43ada27dfc25c0d113f
>
> But since other utilities outside of ftrace may use this trace point, it
> may be OK to keep the duplicate information in the kernel lock API trace
> points.
>
> -- Steve
Right, or may be we can define this tracepoint as a latency format
user by default. It's not possible yet for an event to do that but
I guess we can set a flag for this purpose or something...
Thanks.
prev parent reply other threads:[~2009-09-28 8:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tip-96a2c464de07d7c72988db851c029b204fc59108@git.kernel.org>
2009-09-26 10:05 ` [tip:tracing/core] tracing/bkl: Add bkl ftrace events Steven Rostedt
2009-09-28 8:48 ` Frederic Weisbecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090928084836.GA6142@nowhere \
--to=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox