From: Ingo Molnar <mingo@elte.hu>
To: Len Brown <lenb@kernel.org>
Cc: Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-acpi@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [origin tree build failure] [PATCH] thinkpad-acpi: Fix build on !CONFIG_THINKPAD_ACPI_HOTKEY_POLL
Date: Mon, 28 Sep 2009 17:35:26 +0200 [thread overview]
Message-ID: <20090928153526.GA9231@elte.hu> (raw)
In-Reply-To: <alpine.LFD.2.00.0909272331520.5561@localhost.localdomain>
* Len Brown <lenb@kernel.org> wrote:
>
> > > > drivers/platform/x86/thinkpad_acpi.c | 632 +++++++++++++++++++---------
> > >
> > > -tip testing found that these changes caused a build failure
> > > in drivers/platform/x86/thinkpad_acpi.c when
> > > !CONFIG_THINKPAD_ACPI_HOTKEY_POLL - the fix is attached below.
> >
> > Fixed by a different patch, which will hit mainline soon....
>
> Ingo,
> 2.6.32-rc1 should build fine* -- let me know if it doesn't.
>
> thanks,
> Len Brown, Intel Open Source Technology Center
>
> * module this message, which Henruque assures me will go away soon
> drivers/platform/x86/thinkpad_acpi.c:2225: warning:
> ‘tpacpi_hotkey_driver_mask_set’ defined but not used
well, the warning is fixed properly in my patch, as pointed out in the
changelog. Have you read that?
Ingo
next prev parent reply other threads:[~2009-09-28 15:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-26 5:19 [git pull request] ACPI related patches for 2.6.32-rc0 - part 2 Len Brown
2009-09-27 7:52 ` [origin tree build failure] [PATCH] thinkpad-acpi: Fix build on !CONFIG_THINKPAD_ACPI_HOTKEY_POLL Ingo Molnar
2009-09-27 12:28 ` Henrique de Moraes Holschuh
2009-09-28 3:34 ` Len Brown
2009-09-28 15:35 ` Ingo Molnar [this message]
2009-09-28 19:44 ` Henrique de Moraes Holschuh
2009-10-01 9:57 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090928153526.GA9231@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=hmh@hmh.eng.br \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox