Re: [PATCH 1/2] PM / PCMCIA: Drop second argument of pcmcia_socket_dev_suspend()

Rafael J. Wysocki
2009-09-28T20:15:45Z

On Monday 28 September 2009, Wolfram Sang wrote:
> On Sat, Sep 26, 2009 at 01:25:11AM +0200, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rjw@sisk.pl>
> >
> > pcmcia_socket_dev_suspend() doesn't use its second argument, so it
> > may be dropped safely.
> >
> > This change is necessary for the subsequent yenta suspend/resume fix.
> >
> > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> > ---
> > drivers/pcmcia/at91_cf.c | 2 +-
> > drivers/pcmcia/au1000_generic.c | 2 +-
> > drivers/pcmcia/bfin_cf_pcmcia.c | 2 +-
> > drivers/pcmcia/cs.c | 2 +-
> > drivers/pcmcia/i82092.c | 2 +-
> > drivers/pcmcia/i82365.c | 2 +-
> > drivers/pcmcia/m32r_cfc.c | 2 +-
> > drivers/pcmcia/m32r_pcc.c | 2 +-
> > drivers/pcmcia/m8xx_pcmcia.c | 2 +-
> > drivers/pcmcia/omap_cf.c | 2 +-
> > drivers/pcmcia/pd6729.c | 2 +-
> > drivers/pcmcia/pxa2xx_base.c | 2 +-
> > drivers/pcmcia/sa1100_generic.c | 2 +-
> > drivers/pcmcia/sa1111_generic.c | 2 +-
> > drivers/pcmcia/tcic.c | 2 +-
> > drivers/pcmcia/vrc4171_card.c | 2 +-
> > include/pcmcia/ss.h | 2 +-
>
> Hmm, you are not converting yenta_socket here. Won't that break building the
> kernel (git bisect)?

You're right, I should have modified yenta_socket.c here as well. Will fix.

Thanks,
Rafael