From: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
To: Ben Nizette <bn@niasdigital.com>
Cc: hskinnemoen@atmel.com, spi-devel-general@lists.sourceforge.net,
Linux Kernel list <linux-kernel@vger.kernel.org>,
kernel <kernel@avr32linux.org>,
dbrownell@users.sourceforge.net
Subject: Re: [PATCH] atmel_spi: fix dma addr calculation for len > BUFFER_SIZE
Date: Tue, 29 Sep 2009 08:57:51 +0200 [thread overview]
Message-ID: <20090929085751.3cc1fa3c@hskinnemoen-d830> (raw)
In-Reply-To: <1254185759.7587.180.camel@ben-desktop>
Ben Nizette <bn@niasdigital.com> wrote:
> From: Ben Nizette <bn@niasdigital.com>
> Subject: [PATCH] atmel_spi: make "len" variable name less ambiguous in dma addr calculation
>
> "[PATCH] atmel_spi: fix dma addr calculation for len > BUFFER_SIZE"
> fixed a bug where the "len" variable in atmel_spi_next_xfer_data() was
> taken to be the total number of bytes remaining in the transfer but it
> actually represents the number of bytes which will be sent this dma
> chunk. While the 2 will be the same if there is less than 1 chunk to go
> (or if we aren't using a scratch buffer and therefore aren't breaking
> the transfers in to chunks), they won't be the same in general.
>
> s/len/next_len to reflect the true nature and usage of this variable.
>
> Signed-off-by: Ben Nizette <bn@niasdigital.com>
Excellent, thanks.
Acked-by: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
prev parent reply other threads:[~2009-09-29 6:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-27 5:26 [PATCH] atmel_spi: fix dma addr calculation for len > BUFFER_SIZE Ben Nizette
2009-09-28 7:12 ` Haavard Skinnemoen
2009-09-29 0:55 ` Ben Nizette
2009-09-29 6:57 ` Haavard Skinnemoen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090929085751.3cc1fa3c@hskinnemoen-d830 \
--to=haavard.skinnemoen@atmel.com \
--cc=bn@niasdigital.com \
--cc=dbrownell@users.sourceforge.net \
--cc=hskinnemoen@atmel.com \
--cc=kernel@avr32linux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).