From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Evgeniy Polyakov <zbr@ioremap.net>
Cc: Oleg Nesterov <oleg@redhat.com>,
Evgeny Polyakov <johnpol@2ka.mipt.ru>,
Scott James Remnant <scott@ubuntu.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Matt Helsley <matthltc@us.ibm.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH] connector: Fix sid connector (was: Badness at kernel/softirq.c:143...)
Date: Tue, 29 Sep 2009 16:15:38 +0200 [thread overview]
Message-ID: <200909291615.38457.borntraeger@de.ibm.com> (raw)
In-Reply-To: <20090929140718.GA23858@ioremap.net>
Am Dienstag 29 September 2009 16:07:18 schrieb Evgeniy Polyakov:
> Your patch breaks assumption that task_session(current->group_leader) is
> not equal to new session id, but to check task_session() we need either
> rcu or task lock. Also setsid() return value is not zero or negative
> error, but new session ID or negative error,
Right.
> so I believe attached patch is a proper fix, although it looks rather ugly.
>
> Also proc_sid_connector() uses GFP_KERNEL allocation which is way too
> wrong to use under any locks.
>
> Something like this (not tested :)
Patch compiles and seems to work.
Christian
next prev parent reply other threads:[~2009-09-29 14:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-25 9:23 2.3.31++: Badness at kernel/softirq.c:143 due to new session leader connector Christian Borntraeger
2009-09-29 10:26 ` Christian Borntraeger
[not found] ` <fbbbe0a028fa.4ac1f1c0@2ka.mipt.ru>
2009-09-29 13:24 ` Oleg Nesterov
2009-09-29 13:47 ` [PATCH] connector: Fix sid connector (was: Badness at kernel/softirq.c:143...) Christian Borntraeger
2009-09-29 13:59 ` Oleg Nesterov
2009-09-29 14:07 ` Evgeniy Polyakov
2009-09-29 14:15 ` Christian Borntraeger [this message]
2009-09-29 14:25 ` Oleg Nesterov
2009-09-29 14:45 ` Oleg Nesterov
2009-09-29 15:12 ` Christian Borntraeger
2009-09-29 16:28 ` Oleg Nesterov
2009-09-30 6:43 ` [PATCH] connector: Fix regression introduced by sid connector Christian Borntraeger
2009-10-01 21:14 ` Andrew Morton
2009-10-01 22:29 ` Oleg Nesterov
2009-10-02 6:16 ` Christian Borntraeger
2009-10-14 0:53 ` David Rientjes
2009-09-29 17:07 ` [PATCH] connector: Fix sid connector (was: Badness at kernel/softirq.c:143...) Evgeniy Polyakov
2009-09-29 14:54 ` Evgeniy Polyakov
2009-09-29 15:36 ` Oleg Nesterov
2009-09-29 17:08 ` Evgeniy Polyakov
2009-09-29 13:22 ` 2.3.31++: Badness at kernel/softirq.c:143 due to new session leader connector Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200909291615.38457.borntraeger@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=davem@davemloft.net \
--cc=johnpol@2ka.mipt.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=matthltc@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=scott@ubuntu.com \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox