From: Chris Mason <chris.mason@oracle.com>
To: linux-kernel@vger.kernel.org, jens.axboe@oracle.com, jack@suse.cz
Subject: Re: [PATCH] bdi_sync_writeback should WB_SYNC_NONE first
Date: Tue, 29 Sep 2009 16:47:20 -0400 [thread overview]
Message-ID: <20090929204720.GE6723@think> (raw)
In-Reply-To: <20090925141014.GB15853@think>
On Fri, Sep 25, 2009 at 10:10:14AM -0400, Chris Mason wrote:
> At unmount time, we do writeback in two stages. First we call
> sync_filesystems with wait == 0, and then we call it with wait == 1.
>
> When wait == 1, WB_SYNC_ALL is used. WB_SYNC_ALL will pass wait == 1 to
> the filesystem write_inode function if the inode was I_DIRTY_SYNC, and
> the filesystem write_inode function is then expected to commit the
> running transaction.
>
> The new bdi threads try to keep this two stage writeback, but the
> problem is that they do it by calling bdi_writeback_all, which just
> kicks a few procs here and there and returns.
>
And I can't reproduce any problems with mainline today. ENOTABUG.
-chris
prev parent reply other threads:[~2009-09-29 20:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-25 14:10 [PATCH] bdi_sync_writeback should WB_SYNC_NONE first Chris Mason
2009-09-27 8:34 ` Andrew Morton
2009-09-27 16:44 ` Jens Axboe
2009-09-27 16:52 ` Andrew Morton
2009-09-27 16:55 ` Jens Axboe
2009-09-27 17:10 ` Andrew Morton
2009-09-29 16:13 ` Jan Kara
2009-09-28 13:32 ` Chris Mason
2009-09-29 20:47 ` Chris Mason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090929204720.GE6723@think \
--to=chris.mason@oracle.com \
--cc=jack@suse.cz \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox