Re: [PATCH v3] mfd: ADP5520 Multifunction LCD Backlight and KeypadInput Device Driver

Mark Brown
2009-10-06T16:06:28Z

On Tue, Oct 06, 2009 at 04:05:45PM +0100, Hennerich, Michael wrote:
> >From: Mark Brown [mailto:broonie@opensource.wolfsonmicro.com]

> >According to the datasheet the GPIOs, light sensor and regulator can
> >also generate interrupts?

> Right - I know - but none of the subdevs are currently using this
> functionality.

You weren't very clear on the difference between the current state of
the drivers and the capabilities of the chip there.

> >The GPIOs in particular would benefit from
> >this since this would mean that their interrupts would be usable by
> >generic gpiolib based drivers.

> Right - and I didn't say that I'm not going to add this functionality
> later.
> All the ADP5520 subdevs already merged in 2.6.32 - the MFD core is the
> only remaining part.
> Time is running short and major changes are going to require another
> round of full testing.

Oh, well, that's sad. It would have been worth at least considering
doing something that at least looks like the IRQ infrastructure but now
there's going to be a merge issue with the input tree if anything gets
changed now.