Re: regression in page writeback

Andrew Morton
2009-09-23T02:56:37Z

On Wed, 23 Sep 2009 10:49:58 +0800 Wu Fengguang <fengguang.wu@intel.com> wrote:

> > After the sleep we repoll all queues.
>
> I mean, it is not always necessary. Only when _all_ superblocks cannot
> writeback their inodes (eg. all in congestion), we should wait.

Well. The code will still submit MAX_WRITEBACK_PAGES pages to _some_
queue in that situation.

But yup, maybe that's a bug! Sounds easy to fix. It doesn't justify
rewriting the whole world and then saying "look, the new code is faster
than the old code which had a bug which I knew about but didn't fix".