From: Evgeniy Polyakov <zbr@ioremap.net>
To: Philipp Reisner <philipp.reisner@linbit.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Lars Ellenberg <lars.ellenberg@linbit.com>,
Andrew Morton <akpm@linux-foundation.com>
Subject: Re: [PATCH] connector: Allow permission checking in the receiver callbacks
Date: Wed, 30 Sep 2009 15:20:57 +0400 [thread overview]
Message-ID: <20090930112057.GA15150@ioremap.net> (raw)
In-Reply-To: <1254235692-1631-1-git-send-email-philipp.reisner@linbit.com>
Hi Philipp.
On Tue, Sep 29, 2009 at 04:48:07PM +0200, Philipp Reisner (philipp.reisner@linbit.com) wrote:
> Various users of the connector should actually check if the
> sender's capabilities of a netlink/connector packet are
> actually sufficient for the operation they trigger. Up to
> now the connector framework did not allow the kernel side
> receiver to do so.
>
> This patch set does the groundwork.
>
> Philipp Reisner (4):
> connector: Keep the skb in cn_callback_data
> connector: Provide the sender's credentials to the callback
> connector/dm: Fixed a compilation warning
> connector: Removed the destruct_data callback since it is always
> kfree_skb()
Patches look good to me.
Andrew please apply to the appropriate tree. I do not know whether it is
acceptible now, since it is not a bugfix, but merely a simple cleanup.
Feel free to add my signed off or ack, thank you.
> Documentation/connector/cn_test.c | 2 +-
> Documentation/connector/connector.txt | 8 ++++----
> drivers/connector/cn_queue.c | 12 +++++++-----
> drivers/connector/connector.c | 22 ++++++++--------------
> drivers/md/dm-log-userspace-transfer.c | 3 +--
> drivers/staging/dst/dcore.c | 2 +-
> drivers/staging/pohmelfs/config.c | 2 +-
> drivers/video/uvesafb.c | 2 +-
> drivers/w1/w1_netlink.c | 2 +-
> include/linux/connector.h | 11 ++++-------
> 10 files changed, 29 insertions(+), 37 deletions(-)
--
Evgeniy Polyakov
next prev parent reply other threads:[~2009-09-30 11:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-29 14:48 [PATCH] connector: Allow permission checking in the receiver callbacks Philipp Reisner
2009-09-29 14:48 ` [PATCH] connector: Keep the skb in cn_callback_data Philipp Reisner
2009-09-29 14:48 ` [PATCH] connector: Provide the sender's credentials to the callback Philipp Reisner
2009-09-29 14:48 ` [PATCH] connector/dm: Fixed a compilation warning Philipp Reisner
2009-09-29 14:48 ` [PATCH] connector: Removed the destruct_data callback since it is always kfree_skb() Philipp Reisner
2009-10-04 21:57 ` Andrew Morton
2009-10-04 21:53 ` [PATCH] connector: Provide the sender's credentials to the callback Andrew Morton
2009-10-04 21:50 ` [PATCH] connector: Keep the skb in cn_callback_data Andrew Morton
2009-09-30 11:20 ` Evgeniy Polyakov [this message]
2009-09-30 13:20 ` [PATCH] connector: Allow permission checking in the receiver callbacks Lars Ellenberg
2009-09-30 19:29 ` Evgeniy Polyakov
2009-10-01 8:01 ` Lars Ellenberg
2009-10-04 10:23 ` Evgeniy Polyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090930112057.GA15150@ioremap.net \
--to=zbr@ioremap.net \
--cc=akpm@linux-foundation.com \
--cc=lars.ellenberg@linbit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=philipp.reisner@linbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox