Re: [PATCH] connector: Keep the skb in cn_callback_data

Andrew Morton
2009-10-04T21:51:48Z

On Tue, 29 Sep 2009 16:48:08 +0200 Philipp Reisner <philipp.reisner@linbit.com> wrote:

> Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
> Acked-by: Lars Ellenberg <lars.ellenberg@linbit.com>

Please don't send unchangelogged patches.

> diff --git a/include/linux/connector.h b/include/linux/connector.h
> index 47ebf41..05a7a14 100644
> --- a/include/linux/connector.h
> +++ b/include/linux/connector.h
> @@ -134,8 +134,8 @@ struct cn_callback_id {
> struct cn_callback_data {
> void (*destruct_data) (void *);
> void *ddata;
> -
> - void *callback_priv;
> +
> + struct sk_buff *skb;
> void (*callback) (struct cn_msg *);
>
> void *free;

This one replaces the void* private pointer with the skb but you didn't
explain to us why this was done.

Also, the patch does two things. It _adds_ the skb pointer and it also
_removes_ the opaque void* private-data pointer for the callbacks.
What are the implications of removing callback_priv? Why was this done?