From: Christoph Hellwig <hch@infradead.org>
To: Josh Stone <jistone@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>, "Theodore Ts'o" <tytso@mit.edu>
Subject: Re: [PATCH] ext4: Add a stub for mpage_da_data in the trace header
Date: Wed, 30 Sep 2009 09:33:35 -0400 [thread overview]
Message-ID: <20090930133335.GA14585@infradead.org> (raw)
In-Reply-To: <1254260407-14276-1-git-send-email-jistone@redhat.com>
On Tue, Sep 29, 2009 at 02:40:07PM -0700, Josh Stone wrote:
> The tracepoint ext4_da_write_pages has a struct mpage_da_data*
> parameter, but that struct is only defined in fs/ext4/ext4.h. This
> patch adds a forward declaration for that struct, so this tracepoint
> header can still be used by tools like SystemTap.
That's not what the tracepoints are for anyway. No hacks for out of
tree crap like this please - just use the trace buffer directly like
ftrace and then you don't actually need any data types.
next prev parent reply other threads:[~2009-09-30 13:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-29 21:40 [PATCH] ext4: Add a stub for mpage_da_data in the trace header Josh Stone
2009-09-30 13:33 ` Christoph Hellwig [this message]
2009-09-30 14:20 ` Theodore Tso
2009-09-30 19:45 ` Josh Stone
2009-09-30 21:23 ` Theodore Tso
2009-10-01 0:13 ` Josh Stone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090930133335.GA14585@infradead.org \
--to=hch@infradead.org \
--cc=jistone@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox