Re: kernel BUG at drivers/ide/ide-disk.c:187 (2.6.31)

David Miller
2009-10-01T18:52:52Z

From: David Miller <davem@davemloft.net>
Date: Thu, 01 Oct 2009 11:47:55 -0700 (PDT)

> Please add this test patch and let us know what messages
> you end up with in the logs. It won't BUG() any more,
> so you have to watch for the messages.

Sorry, there's a small bug in the test patch, please use this one
instead.

diff --git a/drivers/ide/ide-disk.c b/drivers/ide/ide-disk.c
index 7f87801..6e0dfa9 100644
--- a/drivers/ide/ide-disk.c
+++ b/drivers/ide/ide-disk.c
@@ -184,7 +184,12 @@ static ide_startstop_t ide_do_rw_disk(ide_drive_t *drive, struct request *rq,
ide_hwif_t *hwif = drive->hwif;

BUG_ON(drive->dev_flags & IDE_DFLAG_BLOCKED);
- BUG_ON(!blk_fs_request(rq));
+ if (!blk_fs_request(rq)) {
+ pr_alert("IDE: Non-FS req in ide_do_rw_disk(), cmd_type %d\n",
+ rq->cmd_type);
+ ide_kill_rq(drive, rq);
+ return ide_stopped;
+ }

ledtrig_ide_activity();