public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Mulyadi Santosa <mulyadi.santosa@gmail.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Paul Mackerras <paulus@samba.org>,
	mingo@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] generate-cmdlist.sh should be either executable or run as parameter of "."
Date: Thu, 1 Oct 2009 10:11:02 +0200	[thread overview]
Message-ID: <20091001081102.GF7733@elte.hu> (raw)
In-Reply-To: <20090930121759.GA14467@merkur.ravnborg.org>


* Sam Ravnborg <sam@ravnborg.org> wrote:

> On Wed, Sep 30, 2009 at 02:08:22PM +0200, Ingo Molnar wrote:
> > 
> > * Mulyadi Santosa <mulyadi.santosa@gmail.com> wrote:
> > 
> > > I believe this is just a small glitch. generate-cmdlist.sh by default 
> > > should be made as executable. But since one might forgot to do it, we 
> > > could simply call it as an argument "." or "source" or even "sh -c". I 
> > > pick "."
> > > 
> > > Tested in 2.6.31
> > > 
> > > Signed-off-by: Mulyadi Santosa <mulyadi.santosa@gmail.com>
> > 
> > hm, generate-cmdlist.sh is executable in the upstream kernel repo. It 
> > apparently isnt executable on your box - why?
> 
> Whatever - we should try to avoid relying on executable bit being set. 
> umask can prevent this is tree is checkout as one user and build as 
> another user.

Fair enough - i'll queue the patch up.

	Ingo

  reply	other threads:[~2009-10-01  8:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-25 19:01 [PATCH] generate-cmdlist.sh should be either executable or run as parameter of "." Mulyadi Santosa
2009-09-30 12:08 ` Ingo Molnar
2009-09-30 12:17   ` Sam Ravnborg
2009-10-01  8:11     ` Ingo Molnar [this message]
2009-10-01  9:58 ` [tip:perf/urgent] perf tools: Run generate-cmdlist.sh properly tip-bot for Mulyadi Santosa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091001081102.GF7733@elte.hu \
    --to=mingo@elte.hu \
    --cc=a.p.zijlstra@chello.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=mulyadi.santosa@gmail.com \
    --cc=paulus@samba.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox