From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: elendil@planet.nl, manty@manty.net, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: kernel BUG at drivers/ide/ide-disk.c:187 (2.6.31)
Date: Thu, 1 Oct 2009 11:25:40 +0200 [thread overview]
Message-ID: <200910011125.40081.bzolnier@gmail.com> (raw)
In-Reply-To: <20091001.013030.98262804.davem@davemloft.net>
On Thursday 01 October 2009 10:30:30 David Miller wrote:
> From: Frans Pop <elendil@planet.nl>
> Date: Thu, 1 Oct 2009 10:26:14 +0200
>
> > Question for IDE maintainers: should maybe the old printing of request info
> > be reinstated, or can the request flags also be obtained from the BUG
> > info?
>
> Using a BUG for this doesn't make it any easier to track down the
> problem. WARN_ON_ONCE() or similar is much more appropriate here.
>
> BUG() is for situations where the system's state is completely
> irrecoverably corrupted, and we cannot continue, and that is not the
> case here at all.
The problem is that you simply cannot know what is the system state here.
Thus when the unknown block layer request is encountered the best thing
you can do is to BUG early instead of allowing the situation when some
requests are silently dropped and possibly causing the data corruption.
next prev parent reply other threads:[~2009-10-01 9:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-30 11:05 kernel BUG at drivers/ide/ide-disk.c:187 (2.6.31) Santiago Garcia Mantinan
2009-10-01 6:57 ` Andrew Morton
2009-10-01 8:26 ` Frans Pop
2009-10-01 8:30 ` David Miller
2009-10-01 9:25 ` Bartlomiej Zolnierkiewicz [this message]
2009-10-01 16:40 ` David Miller
2009-10-01 18:21 ` Bartlomiej Zolnierkiewicz
2009-10-01 18:34 ` David Miller
2009-10-01 18:52 ` Bartlomiej Zolnierkiewicz
2009-10-01 10:11 ` Santiago Garcia Mantinan
2009-10-01 18:47 ` David Miller
2009-10-01 18:53 ` David Miller
2009-10-03 3:39 ` Santiago Garcia Mantinan
2009-10-04 22:37 ` Santiago Garcia Mantinan
2009-10-05 0:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200910011125.40081.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=elendil@planet.nl \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manty@manty.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox