From: Andrew Morton <akpm@linux-foundation.org>
To: Joe Perches <joe@perches.com>
Cc: jbaron@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dynamic_debug.h/kernel.h: Remove KBUILD_MODNAME from dynamic_pr_debug
Date: Thu, 1 Oct 2009 14:57:29 -0700 [thread overview]
Message-ID: <20091001145729.280ffe69.akpm@linux-foundation.org> (raw)
In-Reply-To: <1254342977.2960.114.camel@Joe-Laptop.home>
On Wed, 30 Sep 2009 13:36:17 -0700
Joe Perches <joe@perches.com> wrote:
> If CONFIG_DYNAMIC_DEBUG is enabled and a source file has:
>
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> #include <linux/kernel.h>
>
> dynamic_debug.h will duplicate KBUILD_MODNAME
> in the output string.
>
> Remove the use of KBUILD_MODNAME from the
> output format string generated by dynamic_debug.h
>
> If CONFIG_DYNAMIC_DEBUG is not enabled, no compile-time
> check is done to printk/dev_printk arguments.
>
> Add it.
x86_64 allmodconfig:
crypto/zlib.c: In function 'zlib_compress_update':
crypto/zlib.c:148: warning: initialization makes integer from pointer without a cast
crypto/zlib.c:148: error: initializer element is not computable at load time
crypto/zlib.c:148: error: (near initialization for 'descriptor.primary_hash')
crypto/zlib.c:148: warning: excess elements in struct initializer
crypto/zlib.c:148: warning: (near initialization for 'descriptor')
crypto/zlib.c:160: warning: initialization makes integer from pointer without a cast
crypto/zlib.c:160: error: initializer element is not computable at load time
crypto/zlib.c:160: error: (near initialization for 'descriptor.primary_hash')
crypto/zlib.c:160: warning: excess elements in struct initializer
crypto/zlib.c:160: warning: (near initialization for 'descriptor')
crypto/zlib.c:164: warning: initialization makes integer from pointer without a cast
crypto/zlib.c:164: error: initializer element is not computable at load time
crypto/zlib.c:164: error: (near initialization for 'descriptor.primary_hash')
crypto/zlib.c:164: warning: excess elements in struct initializer
crypto/zlib.c:164: warning: (near initialization for 'descriptor')
crypto/zlib.c:169: warning: initialization makes integer from pointer without a cast
crypto/zlib.c:169: error: initializer element is not computable at load time
crypto/zlib.c:169: error: (near initialization for 'descriptor.primary_hash')
crypto/zlib.c:169: warning: excess elements in struct initializer
crypto/zlib.c:169: warning: (near initialization for 'descriptor')
crypto/zlib.c: In function 'zlib_compress_final':
crypto/zlib.c:186: warning: initialization makes integer from pointer without a cast
crypto/zlib.c:186: error: initializer element is not computable at load time
crypto/zlib.c:186: error: (near initialization for 'descriptor.primary_hash')
crypto/zlib.c:186: warning: excess elements in struct initializer
crypto/zlib.c:186: warning: (near initialization for 'descriptor')
crypto/zlib.c:194: warning: initialization makes integer from pointer without a cast
crypto/zlib.c:194: error: initializer element is not computable at load time
crypto/zlib.c:194: error: (near initialization for 'descriptor.primary_hash')
crypto/zlib.c:194: warning: excess elements in struct initializer
crypto/zlib.c:194: warning: (near initialization for 'descriptor')
crypto/zlib.c:199: warning: initialization makes integer from pointer without a cast
crypto/zlib.c:199: error: initializer element is not computable at load time
crypto/zlib.c:199: error: (near initialization for 'descriptor.primary_hash')
crypto/zlib.c:199: warning: excess elements in struct initializer
crypto/zlib.c:199: warning: (near initialization for 'descriptor')
crypto/zlib.c: In function 'zlib_decompress_update':
crypto/zlib.c:262: warning: initialization makes integer from pointer without a cast
crypto/zlib.c:262: error: initializer element is not computable at load time
crypto/zlib.c:262: error: (near initialization for 'descriptor.primary_hash')
crypto/zlib.c:262: warning: large integer implicitly truncated to unsigned type
crypto/zlib.c:262: warning: excess elements in struct initializer
crypto/zlib.c:262: warning: (near initialization for 'descriptor')
crypto/zlib.c:275: warning: initialization makes integer from pointer without a cast
crypto/zlib.c:275: error: initializer element is not computable at load time
crypto/zlib.c:275: error: (near initialization for 'descriptor.primary_hash')
crypto/zlib.c:275: warning: large integer implicitly truncated to unsigned type
crypto/zlib.c:275: warning: excess elements in struct initializer
crypto/zlib.c:275: warning: (near initialization for 'descriptor')
crypto/zlib.c:279: warning: initialization makes integer from pointer without a cast
crypto/zlib.c:279: error: initializer element is not computable at load time
crypto/zlib.c:279: error: (near initialization for 'descriptor.primary_hash')
crypto/zlib.c:279: warning: large integer implicitly truncated to unsigned type
crypto/zlib.c:279: warning: excess elements in struct initializer
crypto/zlib.c:279: warning: (near initialization for 'descriptor')
crypto/zlib.c:284: warning: initialization makes integer from pointer without a cast
crypto/zlib.c:284: error: initializer element is not computable at load time
crypto/zlib.c:284: error: (near initialization for 'descriptor.primary_hash')
crypto/zlib.c:284: warning: large integer implicitly truncated to unsigned type
crypto/zlib.c:284: warning: excess elements in struct initializer
crypto/zlib.c:284: warning: (near initialization for 'descriptor')
crypto/zlib.c: In function 'zlib_decompress_final':
crypto/zlib.c:301: warning: initialization makes integer from pointer without a cast
crypto/zlib.c:301: error: initializer element is not computable at load time
crypto/zlib.c:301: error: (near initialization for 'descriptor.primary_hash')
crypto/zlib.c:301: warning: large integer implicitly truncated to unsigned type
crypto/zlib.c:301: warning: excess elements in struct initializer
crypto/zlib.c:301: warning: (near initialization for 'descriptor')
crypto/zlib.c:327: warning: initialization makes integer from pointer without a cast
crypto/zlib.c:327: error: initializer element is not computable at load time
crypto/zlib.c:327: error: (near initialization for 'descriptor.primary_hash')
crypto/zlib.c:327: warning: large integer implicitly truncated to unsigned type
crypto/zlib.c:327: warning: excess elements in struct initializer
crypto/zlib.c:327: warning: (near initialization for 'descriptor')
crypto/zlib.c:332: warning: initialization makes integer from pointer without a cast
crypto/zlib.c:332: error: initializer element is not computable at load time
crypto/zlib.c:332: error: (near initialization for 'descriptor.primary_hash')
crypto/zlib.c:332: warning: large integer implicitly truncated to unsigned type
crypto/zlib.c:332: warning: excess elements in struct initializer
crypto/zlib.c:332: warning: (near initialization for 'descriptor')
make[1]: *** [crypto/zlib.o] Error 1
make: *** [crypto/zlib.o] Error 2
next prev parent reply other threads:[~2009-10-01 21:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-30 20:36 [PATCH] dynamic_debug.h/kernel.h: Remove KBUILD_MODNAME from dynamic_pr_debug Joe Perches
2009-10-01 21:08 ` Jason Baron
2009-10-01 21:57 ` Andrew Morton [this message]
2009-10-01 22:58 ` [PATCH v2] " Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091001145729.280ffe69.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=jbaron@redhat.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox