From: Jason Baron <jbaron@redhat.com>
To: Joe Perches <joe@perches.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] dynamic_debug.h/kernel.h: Remove KBUILD_MODNAME from dynamic_pr_debug
Date: Thu, 1 Oct 2009 17:08:46 -0400 [thread overview]
Message-ID: <20091001210846.GE2660@redhat.com> (raw)
In-Reply-To: <1254342977.2960.114.camel@Joe-Laptop.home>
On Wed, Sep 30, 2009 at 01:36:17PM -0700, Joe Perches wrote:
> If CONFIG_DYNAMIC_DEBUG is enabled and a source file has:
>
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> #include <linux/kernel.h>
>
> dynamic_debug.h will duplicate KBUILD_MODNAME
> in the output string.
>
> Remove the use of KBUILD_MODNAME from the
> output format string generated by dynamic_debug.h
>
> If CONFIG_DYNAMIC_DEBUG is not enabled, no compile-time
> check is done to printk/dev_printk arguments.
>
> Add it.
>
looks good. thanks for updating this.
Acked-by: Jason Baron <jbaron@redhat.com>
next prev parent reply other threads:[~2009-10-01 21:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-30 20:36 [PATCH] dynamic_debug.h/kernel.h: Remove KBUILD_MODNAME from dynamic_pr_debug Joe Perches
2009-10-01 21:08 ` Jason Baron [this message]
2009-10-01 21:57 ` Andrew Morton
2009-10-01 22:58 ` [PATCH v2] " Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091001210846.GE2660@redhat.com \
--to=jbaron@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox