From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Breno Leitao <leitao@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] jsm: fixing termios structure to be compatible with stty application
Date: Thu, 1 Oct 2009 22:10:38 +0100 [thread overview]
Message-ID: <20091001221038.4457e8d6@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <4AC51244.1010600@linux.vnet.ibm.com>
> Hence, I just assigned ospeed and ispeed with the requested speed in Bfoo
> format (c_flag & CBAUD).
The kernel ospeed and ispeed are not in Bfoo format, they are actual bit
rates. (I've no idea what glibc does, last time I checked it didn't even
support 2007 era Linux speed setting properly so apps still have to use
ioctls directly for them)
>
> I also tested the tty_termios_encode_baud_rate(), and it will basically do what
> I did:
>
> termios->c_ispeed = ibaud;
> termios->c_ospeed = obaud;
>
> Thanks for the review, and sorry if I missed the point completely.
ibaud != Bfoo
prev parent reply other threads:[~2009-10-01 21:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-30 16:18 [PATCH] jsm: fixing termios structure to be compatible with stty application leitao
2009-09-30 20:31 ` Alan Cox
2009-10-01 20:34 ` Breno Leitao
2009-10-01 21:10 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091001221038.4457e8d6@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=leitao@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox