From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757315AbZJBIKO (ORCPT ); Fri, 2 Oct 2009 04:10:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757273AbZJBIKK (ORCPT ); Fri, 2 Oct 2009 04:10:10 -0400 Received: from brick.kernel.dk ([93.163.65.50]:58928 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757272AbZJBIKJ (ORCPT ); Fri, 2 Oct 2009 04:10:09 -0400 Date: Fri, 2 Oct 2009 10:10:12 +0200 From: Jens Axboe To: KOSAKI Motohiro Cc: LKML , linux-mm , Andrew Morton , Rik van Riel Subject: Re: [PATCH] congestion_wait() don't use WRITE Message-ID: <20091002081012.GH14918@kernel.dk> References: <20091002170343.5F67.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091002170343.5F67.A69D9226@jp.fujitsu.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 02 2009, KOSAKI Motohiro wrote: > > commit 8aa7e847d (Fix congestion_wait() sync/async vs read/write confusion) > replace WRITE with BLK_RW_ASYNC. > Unfortunately, concurrent mm development made the unchanged place > accidentally. I see that was added after 2.6.31, and that is wrong. Your patch looks good. Acked-by: Jens Axboe > > This patch fixes it too. > > Signed-off-by: KOSAKI Motohiro > --- > mm/vmscan.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 4a7b0d5..e4a915b 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1088,7 +1088,7 @@ static unsigned long shrink_inactive_list(unsigned long max_scan, > int lumpy_reclaim = 0; > > while (unlikely(too_many_isolated(zone, file, sc))) { > - congestion_wait(WRITE, HZ/10); > + congestion_wait(BLK_RW_ASYNC, HZ/10); > > /* We are about to die and free our memory. Return now. */ > if (fatal_signal_pending(current)) > -- > 1.6.0.GIT > > > -- Jens Axboe