From: Oliver Neukum <oliver@neukum.org>
To: "Sven-Thorsten Dietrich" <sdietrich@novell.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
"linux-rt-users" <linux-rt-users@vger.kernel.org>
Subject: Re: [PATCH][UHCI-DEBUG] Don't kmalloc with BKL held
Date: Fri, 2 Oct 2009 14:01:36 +0200 [thread overview]
Message-ID: <200910021401.37997.oliver@neukum.org> (raw)
In-Reply-To: <1254474744.28661.2.camel@sven.thebigcorporation.com>
Am Freitag, 2. Oktober 2009 11:12:24 schrieb Sven-Thorsten Dietrich:
> Subject: Don't kmalloc with BKL held.
> From: Sven-Thorsten Dietrich <sdietrich@suse.de>
>
> I'm eyeballing this file for complete removal of lock_kernel but
> at first glance, we definitely don't need BKL to kmalloc().
The reasoning is correct, but this patch screws up the error case.
You also need to move the label.
Regards
Oliver
prev parent reply other threads:[~2009-10-02 11:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-02 9:12 [PATCH][UHCI-DEBUG] Don't kmalloc with BKL held Sven-Thorsten Dietrich
2009-10-02 9:20 ` Frederik Deweerdt
2009-10-03 12:35 ` Sven-Thorsten Dietrich
2009-10-06 7:51 ` Frederik Deweerdt
2009-10-06 10:09 ` Thomas Gleixner
2009-10-02 12:01 ` Oliver Neukum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200910021401.37997.oliver@neukum.org \
--to=oliver@neukum.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=sdietrich@novell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox