From: Andi Kleen <andi@firstfloor.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Andi Kleen <andi@firstfloor.org>,
Arjan van de Ven <arjan@infradead.org>,
linux-kernel@vger.kernel.org, mingo@elte.hu, tglx@tglx.de,
torvalds@linux-foundation.org
Subject: Re: [PATCH] x86: Use __builtin_memset and __builtin_memcpy for memset/memcpy
Date: Fri, 2 Oct 2009 22:12:08 +0200 [thread overview]
Message-ID: <20091002201208.GO1656@one.firstfloor.org> (raw)
In-Reply-To: <4AC65CC9.4000105@zytor.com>
On Fri, Oct 02, 2009 at 01:04:25PM -0700, H. Peter Anvin wrote:
> On 10/02/2009 12:19 PM, Andi Kleen wrote:
> >
> > I tried this some time ago, but it it generates bad code on some
> > gcc 3 versions.
> >
> > You really need to test such kind of changes on a wide variety
> > of compilers, not assuming everyone uses the same version as you.
> >
>
> The version that went in is for gcc 4 only.
Thanks.
My memory might be faulty, but iirc 4.0/4.1 was also slightly
problematic. So better take a look at code for that too
if you haven't yet (just code size numbers are not enough)
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
prev parent reply other threads:[~2009-10-02 20:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-28 9:34 [PATCH] x86: Use __builtin_memset and __builtin_memcpy for memset/memcpy Arjan van de Ven
2009-09-28 12:21 ` Arjan van de Ven
2009-09-28 23:47 ` [tip:x86/asm] " tip-bot for Arjan van de Ven
2009-09-29 12:44 ` [PATCH] " Arnd Bergmann
2009-09-29 12:53 ` Arjan van de Ven
2009-09-29 15:32 ` H. Peter Anvin
2009-10-02 19:19 ` Andi Kleen
2009-10-02 20:04 ` H. Peter Anvin
2009-10-02 20:12 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091002201208.GO1656@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=arjan@infradead.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@tglx.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox