Re: [PATCH 3/3] EDAC: carve out AMD MCE decoding logic

Borislav Petkov
2009-10-02T18:26:53Z

On Fri, Oct 02, 2009 at 03:39:54PM +0200, Ingo Molnar wrote:
> I suspect this is fine currently because no two EDAC modules should be
> active at the same time. A followup cleanup patch would be nice
> nevertheless that uses a notifier chain here with proper
> register/unregister locking.

Please do elaborate for I can't seem to follow.

AFAICT, we are going to have max one MCE decoder at any one time so no
need to notify it.

The x86_mce_decode_callback assignment probably needs locking just to be
on the safe side. We can do a

mce_set_decode_callback(void (*f)(struct mce*m))

helper which falls back to default_decode_mce() whenever its being
passed a NULL for *f using proper locking...

I'm pretty sure I'm missing something though...

--
Regards/Gruss,
Boris.

Operating | Advanced Micro Devices GmbH
System | Karl-Hammerschmidt-Str. 34, 85609 Dornach b. München, Germany
Research | Geschäftsführer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni
Center | Sitz: Dornach, Gemeinde Aschheim, Landkreis München
(OSRC) | Registergericht München, HRB Nr. 43632