linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Cc: Daniel Lezcano <dlezcano@fr.ibm.com>,
	Sukadev Bhattiprolu <sukadev@us.ibm.com>,
	Linux Containers <containers@lists.osdl.org>,
	roland@redhat.com, linux-kernel@vger.kernel.org
Subject: [PATCH 0/4] Was: pidns : PR_SET_PDEATHSIG + SIGKILL regression
Date: Sun, 4 Oct 2009 04:18:44 +0200	[thread overview]
Message-ID: <20091004021844.GA21006@redhat.com> (raw)
In-Reply-To: <20091003171029.GA30442@us.ibm.com>

On 10/03, Sukadev Bhattiprolu wrote:
>
>  static void reparent_thread(struct task_struct *father, struct task_struct *p,
>  				struct list_head *dead)
>  {
> -	if (p->pdeath_signal)
> -		group_send_sig_info(p->pdeath_signal, SEND_SIG_NOINFO, p);
> +	if (p->pdeath_signal) {
> +		struct siginfo info;
> +
> +		info.si_code = SI_USER;
> +		info.si_signo = p->pdeath_signal;
> +		info.si_errno = 0;
> +
> +		rcu_read_lock();
> +		info.si_pid = task_tgid_nr_ns(father, task_active_pid_ns(p));
> +		info.si_uid = __task_cred(father)->uid;
> +		rcu_read_unlock();
> +
> +		group_send_sig_info(p->pdeath_signal, &info, p);
> +	}

I think the patch is correct.

But afaics we should clarify the "from user" semantics and fix
send_signal() instead.

What do you think about this simple series? (the last 2 patches
are pure cosmetic and off-topic).

Oleg.


  reply	other threads:[~2009-10-04  2:23 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4AC608BE.9020805@fr.ibm.com>
2009-10-03 17:10 ` pidns : PR_SET_PDEATHSIG + SIGKILL regression Sukadev Bhattiprolu
2009-10-04  2:18   ` Oleg Nesterov [this message]
2009-10-04  2:19     ` [PATCH 1/4] signals: SEND_SIG_NOINFO should be considered as SI_FROMUSER() Oleg Nesterov
2009-10-04  2:25       ` Oleg Nesterov
2009-10-05 17:58       ` Sukadev Bhattiprolu
2009-10-05 18:39         ` Oleg Nesterov
2009-10-06  0:09       ` Sukadev Bhattiprolu
2009-10-06  7:31       ` Roland McGrath
2009-10-06 13:37         ` Oleg Nesterov
2009-10-06 17:57           ` Roland McGrath
2009-10-07 11:30             ` Oleg Nesterov
2009-10-08  1:57               ` Roland McGrath
2009-10-04  2:19     ` [PATCH 2/4] signals: send_signal: use si_fromuser() to detect from_ancestor_ns Oleg Nesterov
2009-10-05 18:12       ` Sukadev Bhattiprolu
2009-10-05 18:25         ` Oleg Nesterov
2009-10-05 19:37           ` Sukadev Bhattiprolu
2009-10-05 19:44             ` Oleg Nesterov
2009-10-05 19:55               ` Oleg Nesterov
2009-10-06  0:06               ` Sukadev Bhattiprolu
2009-10-06  1:09                 ` Oleg Nesterov
2009-10-06  2:34                   ` Sukadev Bhattiprolu
2009-10-06 13:18                     ` Oleg Nesterov
2009-10-06 18:01                       ` Roland McGrath
2009-10-06  0:16       ` Sukadev Bhattiprolu
2009-10-04  2:20     ` [PATCH 3/4] signals: cosmetic, collect_signal: use SI_USER Oleg Nesterov
2009-10-05 18:03       ` Sukadev Bhattiprolu
2009-10-04  2:20     ` [PATCH 4/4] signals: kill force_sig_specific() Oleg Nesterov
2009-10-05 18:04       ` Sukadev Bhattiprolu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091004021844.GA21006@redhat.com \
    --to=oleg@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=containers@lists.osdl.org \
    --cc=dlezcano@fr.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roland@redhat.com \
    --cc=sukadev@linux.vnet.ibm.com \
    --cc=sukadev@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).