From: Andrew Morton <akpm@linux-foundation.org>
To: Philipp Reisner <philipp.reisner@linbit.com>
Cc: Evgeniy Polyakov <zbr@ioremap.net>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Lars Ellenberg <lars.ellenberg@linbit.com>
Subject: Re: [PATCH] connector: Provide the sender's credentials to the callback
Date: Sun, 4 Oct 2009 14:53:49 -0700 [thread overview]
Message-ID: <20091004145349.bc7b1857.akpm@linux-foundation.org> (raw)
In-Reply-To: <1254235692-1631-3-git-send-email-philipp.reisner@linbit.com>
On Tue, 29 Sep 2009 16:48:09 +0200 Philipp Reisner <philipp.reisner@linbit.com> wrote:
> Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
> Acked-by: Lars Ellenberg <lars.ellenberg@linbit.com>
Please don't send unchangelogged patches.
The title tells us what the patch does, but how is the reader supposed
to work out why it does it?
> diff --git a/drivers/md/dm-log-userspace-transfer.c b/drivers/md/dm-log-userspace-transfer.c
> index ba0edad..556131f 100644
> --- a/drivers/md/dm-log-userspace-transfer.c
> +++ b/drivers/md/dm-log-userspace-transfer.c
> @@ -129,7 +129,7 @@ static int fill_pkg(struct cn_msg *msg, struct dm_ulog_request *tfr)
> * This is the connector callback that delivers data
> * that was sent from userspace.
> */
> -static void cn_ulog_callback(void *data)
> +static void cn_ulog_callback(void *data, struct netlink_skb_parms *nsp)
> {
> struct cn_msg *msg = (struct cn_msg *)data;
> struct dm_ulog_request *tfr = (struct dm_ulog_request *)(msg + 1);
Your "connector/dm: Fixed a compilation warning" fix is already in
linux-next, so we throw a small and easily-fixed reject here.
next prev parent reply other threads:[~2009-10-04 21:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-29 14:48 [PATCH] connector: Allow permission checking in the receiver callbacks Philipp Reisner
2009-09-29 14:48 ` [PATCH] connector: Keep the skb in cn_callback_data Philipp Reisner
2009-09-29 14:48 ` [PATCH] connector: Provide the sender's credentials to the callback Philipp Reisner
2009-09-29 14:48 ` [PATCH] connector/dm: Fixed a compilation warning Philipp Reisner
2009-09-29 14:48 ` [PATCH] connector: Removed the destruct_data callback since it is always kfree_skb() Philipp Reisner
2009-10-04 21:57 ` Andrew Morton
2009-10-04 21:53 ` Andrew Morton [this message]
2009-10-04 21:50 ` [PATCH] connector: Keep the skb in cn_callback_data Andrew Morton
2009-09-30 11:20 ` [PATCH] connector: Allow permission checking in the receiver callbacks Evgeniy Polyakov
2009-09-30 13:20 ` Lars Ellenberg
2009-09-30 19:29 ` Evgeniy Polyakov
2009-10-01 8:01 ` Lars Ellenberg
2009-10-04 10:23 ` Evgeniy Polyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091004145349.bc7b1857.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=lars.ellenberg@linbit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=philipp.reisner@linbit.com \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox