From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752427AbZJEOCD (ORCPT ); Mon, 5 Oct 2009 10:02:03 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751118AbZJEOCC (ORCPT ); Mon, 5 Oct 2009 10:02:02 -0400 Received: from thunk.org ([69.25.196.29]:38567 "EHLO thunker.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750966AbZJEOCC (ORCPT ); Mon, 5 Oct 2009 10:02:02 -0400 Date: Mon, 5 Oct 2009 10:01:18 -0400 From: Theodore Tso To: Jan Kara Cc: Linux Kernel Developers List , sandeen@redhat.com Subject: Re: [PATCH] ext3: Don't update superblock write time when filesystem is read-only Message-ID: <20091005140118.GD13512@mit.edu> Mail-Followup-To: Theodore Tso , Jan Kara , Linux Kernel Developers List , sandeen@redhat.com References: <1254625958-3588-1-git-send-email-tytso@mit.edu> <20091005122409.GC8388@duck.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091005122409.GC8388@duck.suse.cz> User-Agent: Mutt/1.5.18 (2008-05-17) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@mit.edu X-SA-Exim-Scanned: No (on thunker.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 05, 2009 at 02:24:09PM +0200, Jan Kara wrote: > On Sat 03-10-09 23:12:38, Theodore Ts'o wrote: > > This avoids updating the superblock write time when we are mounting > > the root file system read/only but we need to replay the journal; at > > that point, for people who are east of GMT and who make their clock > > tick in localtime for Windows bug-for-bug compatibility, and this will > > cause e2fsck to complain and force a full file system check. > Thanks, the patch is queued in my queue already. I just held it for a > while because Eric also had a valid point - maybe fsck is too strict when > it forces a full filesystem check just because the superblock write time is > in future? On a pc-class hw, clocks go often wrong. Even I remember setting > system clock on my desktop a few hours back because it just gets out of > sync and I don't run NTP... > So I'm not against your patch because it can help in some cases and > it's not a big deal but I think a proper fix would be in fsck... Regardless of whether fsck relaxes its check, if the filesystem is mounted read-only, I don't think the last write time should change... - Ted