From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Daniel Lezcano <dlezcano@fr.ibm.com>,
Sukadev Bhattiprolu <sukadev@us.ibm.com>,
Linux Containers <containers@lists.osdl.org>,
roland@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] signals: cosmetic, collect_signal: use SI_USER
Date: Mon, 5 Oct 2009 11:03:54 -0700 [thread overview]
Message-ID: <20091005180354.GC30442@us.ibm.com> (raw)
In-Reply-To: <20091004022021.GD21006@redhat.com>
Oleg Nesterov [oleg@redhat.com] wrote:
| Trivial, s/0/SI_USER/ in collect_signal() for grep.
|
| This is a bit confusing, we don't know the source of this signal.
| But we don't care, and "info->si_code = 0" is imho worse.
|
| Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Reviewed-by: Sukadev Bhattiprolu <sukadev@us.ibm.com>
| ---
|
| kernel/signal.c | 2 +-
| 1 file changed, 1 insertion(+), 1 deletion(-)
|
| --- TTT_32/kernel/signal.c~3_COLLECT_SIGNAL 2009-10-04 03:09:44.000000000 +0200
| +++ TTT_32/kernel/signal.c 2009-10-04 03:48:48.000000000 +0200
| @@ -400,7 +400,7 @@ still_pending:
| */
| info->si_signo = sig;
| info->si_errno = 0;
| - info->si_code = 0;
| + info->si_code = SI_USER;
| info->si_pid = 0;
| info->si_uid = 0;
| }
next prev parent reply other threads:[~2009-10-05 18:04 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4AC608BE.9020805@fr.ibm.com>
2009-10-03 17:10 ` pidns : PR_SET_PDEATHSIG + SIGKILL regression Sukadev Bhattiprolu
2009-10-04 2:18 ` [PATCH 0/4] Was: " Oleg Nesterov
2009-10-04 2:19 ` [PATCH 1/4] signals: SEND_SIG_NOINFO should be considered as SI_FROMUSER() Oleg Nesterov
2009-10-04 2:25 ` Oleg Nesterov
2009-10-05 17:58 ` Sukadev Bhattiprolu
2009-10-05 18:39 ` Oleg Nesterov
2009-10-06 0:09 ` Sukadev Bhattiprolu
2009-10-06 7:31 ` Roland McGrath
2009-10-06 13:37 ` Oleg Nesterov
2009-10-06 17:57 ` Roland McGrath
2009-10-07 11:30 ` Oleg Nesterov
2009-10-08 1:57 ` Roland McGrath
2009-10-04 2:19 ` [PATCH 2/4] signals: send_signal: use si_fromuser() to detect from_ancestor_ns Oleg Nesterov
2009-10-05 18:12 ` Sukadev Bhattiprolu
2009-10-05 18:25 ` Oleg Nesterov
2009-10-05 19:37 ` Sukadev Bhattiprolu
2009-10-05 19:44 ` Oleg Nesterov
2009-10-05 19:55 ` Oleg Nesterov
2009-10-06 0:06 ` Sukadev Bhattiprolu
2009-10-06 1:09 ` Oleg Nesterov
2009-10-06 2:34 ` Sukadev Bhattiprolu
2009-10-06 13:18 ` Oleg Nesterov
2009-10-06 18:01 ` Roland McGrath
2009-10-06 0:16 ` Sukadev Bhattiprolu
2009-10-04 2:20 ` [PATCH 3/4] signals: cosmetic, collect_signal: use SI_USER Oleg Nesterov
2009-10-05 18:03 ` Sukadev Bhattiprolu [this message]
2009-10-04 2:20 ` [PATCH 4/4] signals: kill force_sig_specific() Oleg Nesterov
2009-10-05 18:04 ` Sukadev Bhattiprolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091005180354.GC30442@us.ibm.com \
--to=sukadev@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=containers@lists.osdl.org \
--cc=dlezcano@fr.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=roland@redhat.com \
--cc=sukadev@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).