From: Jens Axboe <jens.axboe@oracle.com>
To: Corrado Zoccolo <czoccolo@gmail.com>
Cc: Linux-Kernel <linux-kernel@vger.kernel.org>
Subject: Re: bug in elevator/cfq regarding start_time?
Date: Tue, 6 Oct 2009 09:12:02 +0200 [thread overview]
Message-ID: <20091006071202.GC5216@kernel.dk> (raw)
In-Reply-To: <4e5e476b0910051326g559bf135ma3cf82219ade497@mail.gmail.com>
On Mon, Oct 05 2009, Corrado Zoccolo wrote:
> On Mon, Oct 5, 2009 at 5:08 PM, Corrado Zoccolo <czoccolo@gmail.com> wrote:
> > On Sun, Oct 4, 2009 at 10:59 PM, Jens Axboe <jens.axboe@oracle.com> wrote:
> >> Good spotting! So we can either add the same copy in cfq, or we can just
> >> move the ->start_time check and assignment in attempt_merge() to post
> >> the elv_merge_requests() call. I think the latter would work fine, but
> >> I'll check and fix tomorrow.
> >
> > I think there is still something buggy regarding those timestamps.
> False alarm. I just found that the list was not yet filled at that
> place in the code.
OK, it did look a bit puzzling. FWIW, this is what I committed
yesterday:
http://git.kernel.dk/?p=linux-2.6-block.git;a=commit;h=30996f40bffe73f05abb92a4cec254befa8cecf7
--
Jens Axboe
next prev parent reply other threads:[~2009-10-06 7:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-04 20:54 bug in elevator/cfq regarding start_time? Corrado Zoccolo
2009-10-04 20:59 ` Jens Axboe
2009-10-05 15:08 ` Corrado Zoccolo
2009-10-05 20:26 ` Corrado Zoccolo
2009-10-06 7:12 ` Jens Axboe [this message]
2009-10-06 8:43 ` Corrado Zoccolo
2009-10-06 8:54 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091006071202.GC5216@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=czoccolo@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).