From: Christoph Hellwig <hch@infradead.org>
To: Tom Zanussi <tzanussi@gmail.com>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, fweisbec@gmail.com,
rostedt@goodmis.org, lizf@cn.fujitsu.com
Subject: Re: [PATCH 2/3] perf trace: Update eval_flag() flags array to match interrupt.h
Date: Tue, 6 Oct 2009 09:27:32 -0400 [thread overview]
Message-ID: <20091006132732.GA14978@infradead.org> (raw)
In-Reply-To: <1254808849-7829-3-git-send-email-tzanussi@gmail.com>
On Tue, Oct 06, 2009 at 01:00:48AM -0500, Tom Zanussi wrote:
> Add missing BLOCK_IOPOLL_SOFTIRQ entry.
Nothing against your patch which is good for the short term, but the
existance of this code is a major design flaw. The trace events are
supposed to be self describing and having them duplicated in the trace
tool means either we're not using that self-description or it's not
good enough to be used.
We'll soon add a lot more flags (e.g. my xfs tracing patch if I can ever
get the formal maintainer to review it will add various), and it was
also made pretty clear that perf while packaged with the kernel should
work independent of the actual kernel version, e.g. one perf binary
should work with older host kernels too which might have very different
flag values.
next prev parent reply other threads:[~2009-10-06 13:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-06 6:00 [PATCH 0/3] a few tracing bugfixes Tom Zanussi
2009-10-06 6:00 ` [PATCH 1/3] perf trace: Remove unused code in builtin-trace.c Tom Zanussi
2009-10-06 12:16 ` [tip:perf/urgent] " tip-bot for Tom Zanussi
2009-10-06 6:00 ` [PATCH 2/3] perf trace: Update eval_flag() flags array to match interrupt.h Tom Zanussi
2009-10-06 12:16 ` [tip:perf/urgent] " tip-bot for Tom Zanussi
2009-10-06 13:27 ` Christoph Hellwig [this message]
2009-10-06 15:19 ` [PATCH 2/3] " Frederic Weisbecker
2009-10-06 15:21 ` Christoph Hellwig
2009-10-06 15:22 ` Frederic Weisbecker
2009-10-06 15:24 ` Christoph Hellwig
2009-10-06 21:42 ` Frederic Weisbecker
2009-10-07 1:17 ` Steven Rostedt
2009-10-06 15:25 ` Frederic Weisbecker
2009-10-11 8:53 ` Ingo Molnar
2009-10-11 12:21 ` Christoph Hellwig
2009-10-16 8:47 ` Ingo Molnar
2009-10-06 6:00 ` [PATCH 3/3] tracing/syscalls: Use long for syscall ret format and field definitions Tom Zanussi
2009-10-06 7:15 ` Frédéric Weisbecker
2009-10-07 3:59 ` Tom Zanussi
2009-10-06 12:17 ` [tip:perf/urgent] " tip-bot for Tom Zanussi
2009-10-06 7:16 ` [PATCH 0/3] a few tracing bugfixes Frédéric Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091006132732.GA14978@infradead.org \
--to=hch@infradead.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).