From: Alan Cox <alan@linux.intel.com>
To: jeff@garzik.org, linux-kernel@vger.kernel.org
Subject: [PATCH] pata_sc1200: Fix crash on boot
Date: Tue, 06 Oct 2009 16:07:51 +0100 [thread overview]
Message-ID: <20091006150737.9610.81541.stgit@localhost.localdomain> (raw)
The SC1200 needs a NULL terminator or it may cause a crash on boot.
Bug #14227
Also correct a bogus comment as the driver had serializing added so can run
dual port.
Signed-off-by: Alan Cox <alan@linux.intel.com>
---
drivers/ata/pata_sc1200.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/pata_sc1200.c b/drivers/ata/pata_sc1200.c
index f49814d..3bbed83 100644
--- a/drivers/ata/pata_sc1200.c
+++ b/drivers/ata/pata_sc1200.c
@@ -235,8 +235,7 @@ static int sc1200_init_one(struct pci_dev *dev, const struct pci_device_id *id)
.udma_mask = ATA_UDMA2,
.port_ops = &sc1200_port_ops
};
- /* Can't enable port 2 yet, see top comments */
- const struct ata_port_info *ppi[] = { &info, };
+ const struct ata_port_info *ppi[] = { &info, NULL };
return ata_pci_sff_init_one(dev, ppi, &sc1200_sht, NULL);
}
next reply other threads:[~2009-10-06 15:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-06 15:07 Alan Cox [this message]
2009-10-14 1:56 ` [PATCH] pata_sc1200: Fix crash on boot Andrew Morton
2009-10-14 3:07 ` Alexandros C. Couloumbis
2009-10-14 12:00 ` Alan Cox
2009-10-14 12:12 ` Bartlomiej Zolnierkiewicz
2009-10-14 12:25 ` Alan Cox
2009-10-14 12:52 ` Jeff Garzik
2009-10-14 12:38 ` Alan Cox
2009-10-16 10:26 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091006150737.9610.81541.stgit@localhost.localdomain \
--to=alan@linux.intel.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).