Re: [PATCH 1/1] Kobject: bail early if no new_parent in kobject_move()

Cornelia Huck
2009-10-06T13:34:13Z

On Tue, 06 Oct 2009 11:52:09 +0300,
Phil Carmody <ext-phil.2.carmody@nokia.com> wrote:

> On Mon, 2009-10-05 at 18:37 +0200, ext Cornelia Huck wrote:
> > On Thu, 1 Oct 2009 17:50:48 +0300,
> > Phil Carmody <ext-phil.2.carmody@nokia.com> wrote:
> >
> > > From: Phil Carmody <ext-phil.2.carmody@nokia.com>
> > >
> > > In the absense of kobj->kset, new_parent would remain NULL.
> > > NULL-dereference shenanighans then ensues in the subsequent
> > > sysfs_move_dir(..., new_parent) call. Bail early instead.
> >
> > But sysfs_move_dir(..., NULL) should work and fall back to the sysfs
> > root...
>
> I guess there are two schools of thought - the strict and the
> accommodating. I was contemplating resending an even stricter patch, but
> there's nothing wrong with adopting sane safe fallbacks instead.

I made all the *_move() functions legal for a NULL destination (see
c744aeae9d173a953b771a7ad5c872f91fa99dec), so I'd like to have it back
that way :)

I've put the patch on my s390 system and ran through sysfs_move();
proper patch posting follows.