Re: [PATCH] Changes to integrate RAR with SEP and fix RAR problems

[Greg KH <greg@kroah.com>]

On Tue, Oct 06, 2009 at 01:45:53PM -0700, Mark Allyn wrote:
> SEP stands for Security Processor; a dedicated processor
> that does encryption, decryption, key management, and
> secure storage.
> 
> RAR stands for Restricted Access Region; this is memory
> aboard the MID platform that is restricted (via hardware)
> from access by software running on the x86 processor.
> Dedicated 'smart' peripherals such as sound, video, and
> encryption can access these regions of memory. They are here
> to help protect copyrighted midia from being illegally copied.

How does it allow "fair-use" copying?  To prevent that is considered
illegal in some juristictions :)

> This is upstream revision 4 of the RAR driver.
> 
> This is a patch referenced from the linux-next repository
> as pulled on October 6, 2009; from the following URL:

Why are you deleting the existing driver entirely?  Why not just patch
it to have whatever new things you need here?

> git://git.kernel.org/pub/scm/linux/kernel/git/sfr/linux-next.git
> 
> This is a modified RAR driver to include integration with
> the SEP driver
> 
> Plese be aware that the SEP driver requires this driver
> in order to compile and run. There are API function calls
> within this driver that are required by the SEP driver.
> 
> Other drivers being developed in the future will also 
> require this driver.

What drivers?  In what way will it be required?

Your patch contains a number of obvious problems that
scripts/checkpatch.pl would have caught.  Please run it through that
before submitting it again.

I'll not take this version for the above reasons.

thanks,

greg k-h